-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get right solution #5734
get right solution #5734
Conversation
Viktor-1995
commented
Nov 25, 2024
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 While you've made great progress, there are a few critical issues that need to be addressed before we can approve the pull request:
-
CSS Variable for Blue Color: It's important to define the blue color as a CSS variable instead of using it directly. This will enhance maintainability and flexibility.
-
Descriptive
href
Attributes: Ensure that thehref
attributes in your<a>
tags point to valid URLs or are more descriptive. This is crucial for navigation and usability.
These changes are essential to meet the core requirements of the task. Once you've addressed these points, feel free to resubmit your pull request. Keep up the great work, and I'm confident you'll nail it! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
<h1>Moyo header</h1> | ||
<header class="header"> | ||
<div class="nav-logo"> | ||
<a href="home"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href
attribute value 'home' should ideally be a valid URL or a more descriptive path, such as './home.html'.
<ul class="nav-items"> | ||
<li> | ||
<a | ||
href="apple" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href
attribute value 'apple' should ideally be a valid URL or a more descriptive path, such as './apple.html'.
<li><a href="smartphones">Smartphones</a></li> | ||
<li> | ||
<a | ||
href="Laptops" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href
attribute value 'Laptops' should ideally be a valid URL or a more descriptive path, such as './laptops.html'.
@@ -1,3 +1,84 @@ | |||
body { | |||
margin: 0; | |||
font-family: Roboto, sans-serif; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the 'Roboto' font is properly loaded in your HTML file. This is crucial for the font-family to be applied correctly.