Develop #5729
Develop #5729
Conversation
Oksana-24
commented
Nov 25, 2024
Oksana-24
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 While you've made a great effort, there are a few critical issues that need to be addressed before we can approve the pull request:
-
HTML Link Href Property: The
hrefattribute for the 'PHOTO' link is set to"3", which is likely incorrect. This needs to be a valid URL or path to ensure the link functions correctly. -
CSS Selector Usage: The use of the universal selector
*in your CSS can impact performance and should be avoided. Consider using more specific selectors. -
CSS Fallback Fonts: It's important to include fallback fonts for
Robototo ensure text is displayed correctly if the primary font fails to load. -
CSS Variable for Blue Color: Implementing a CSS variable for the blue color will improve maintainability and meet the task requirements.
-
HTML Semantic Tags: Ensure that semantic tags like
<nav>and<ul>are used correctly. The<nav>tag should not contain the logo. -
CSS Pseudo-element for Active Link: Implement a pseudo-element for the blue line below the active link to meet the design requirements.
-
HTML Indentation: Consistently use 2 spaces for indentation to improve readability and maintain consistency.
Please address these issues, and feel free to reach out if you need any help. Once these changes are made, we can proceed with the approval. Keep up the great work! 🌟
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/index.html
Outdated
| class="main-nav__link" | ||
| href="3" |
There was a problem hiding this comment.
The href attribute for the 'PHOTO' link is set to '3', which is likely incorrect. It should be a valid URL or path. Please verify and correct this link.
|
fixed all remark |
src/style.css
Outdated
| @media (min-width: 1024px) and (max-width: 1200px) { | ||
| a[data-qa='hover'] { | ||
| color: #000; |
src/style.css
Outdated
| a[data-qa='hover'] { | ||
| color: #00acdc; | ||
| } |
There was a problem hiding this comment.
why do you need it? styles for hover already settled above
Co-authored-by: Denys Semtso <[email protected]>
