chore: all the requirements are ok #4834
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anastasiiavorobiova
suggested changes
Apr 11, 2024
src/index.html
Outdated
| <link | ||
| rel="stylesheet" | ||
| href="./style.css" | ||
| /> | ||
| </head> | ||
| <body> | ||
| <h1>Moyo header</h1> | ||
| <header class="header"> | ||
| <div class="container"> |
There was a problem hiding this comment.
Suggested change
| <div class="container"> | |
There was a problem hiding this comment.
I have these line in my commit. when is a QA call to ask questions?
src/style.css
Outdated
|
|
||
| .header { | ||
| width: 100%; | ||
| max-width: 1920px; |
There was a problem hiding this comment.
Suggested change
| max-width: 1920px; | |
| padding: 0 50px; | |
| display: flex; | |
| justify-content: space-between; | |
| align-items: center; |
src/style.css
Outdated
Comment on lines
20
to
27
| .container { | ||
| margin: 0 auto; | ||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| width: 100%; | ||
| max-width: 1200px; | ||
| } |
There was a problem hiding this comment.
Suggested change
| .container { | |
| margin: 0 auto; | |
| display: flex; | |
| justify-content: space-between; | |
| align-items: center; | |
| width: 100%; | |
| max-width: 1200px; | |
| } |
There was a problem hiding this comment.
is it for .header or .container suggestion?
| @@ -1,3 +1,78 @@ | |||
| body { | |||
| * { | |||
| margin: 0; | |||
There was a problem hiding this comment.
Suggested change
| margin: 0; | |
| margin: 0; | |
| box-sizing: border-box; |
src/style.css
Outdated
Comment on lines
34
to
36
| .nav { | ||
| margin-right: 50px; | ||
| } |
There was a problem hiding this comment.
Suggested change
| .nav { | |
| margin-right: 50px; | |
| } |
There was a problem hiding this comment.
I don't see any change
|
|
|
@anastasiiavorobiova I can see tests are ok on GitHub but locally all the tests fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.