-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial commit #2669
base: master
Are you sure you want to change the base?
initial commit #2669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start :D remember to ask for another review after completing each section or block ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Przepraszam, że tak dużo na raz wrzucam, zapomnialem zeby po kazdym bloku dawac review :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey. Good job! I see some problems with spacing for example on phone this spacing should be lower.
It would also be a good idea to review the checklist.md file in the repository. I’ve already noticed that some items are missing. For instance, the navigation menu should prevent scrolling when open, and the address link is missing, among other things.
Also I see that you didn't change the image as Natalia has suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-Hover effect on images is shifting layout and also scale is too big it covers text under images.
-Fix menu for small screens (if there is not enough space for all the menu item (that's number 17 from the checklist)
thank you for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fotka roweru z hero image jest zmieniona na wieksza?
tak, zmienilem |
https://MarcinMaka37.github.io/layout_miami/