Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit #2669

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open

initial commit #2669

wants to merge 37 commits into from

Conversation

MarcinMaka37
Copy link

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start :D remember to ask for another review after completing each section or block ;)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this img has poor quality so you should use big full img and cover the sides ;)
image

@MarcinMaka37
Copy link
Author

Przepraszam, że tak dużo na raz wrzucam, zapomnialem zeby po kazdym bloku dawac review :/

Copy link

@Zibi95 Zibi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. Good job! I see some problems with spacing for example on phone this spacing should be lower.
{76A0D544-7892-47DB-9C79-D1F41E604086}

It would also be a good idea to review the checklist.md file in the repository. I’ve already noticed that some items are missing. For instance, the navigation menu should prevent scrolling when open, and the address link is missing, among other things.

@Zibi95
Copy link

Zibi95 commented Dec 6, 2024

Also I see that you didn't change the image as Natalia has suggested.

@MarcinMaka37 MarcinMaka37 requested a review from Zibi95 December 12, 2024 17:12
Copy link

@Zibi95 Zibi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Hover effect on images is shifting layout and also scale is too big it covers text under images.
-Fix menu for small screens (if there is not enough space for all the menu item (that's number 17 from the checklist)

@MarcinMaka37
Copy link
Author

thank you for review :)

@MarcinMaka37 MarcinMaka37 requested a review from Zibi95 December 13, 2024 15:02
Copy link

@danon321 danon321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fotka roweru z hero image jest zmieniona na wieksza?

@MarcinMaka37
Copy link
Author

tak, zmienilem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants