Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bose_landing #2666

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

bose_landing #2666

wants to merge 5 commits into from

Conversation

iteamfox
Copy link

No description provided.

Zibi95
Zibi95 suggested changes Oct 21, 2024
View reviewed changes
Copy link

@Zibi95 Zibi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. Please provide DEMO link so I can review the task.

@iteamfox
Copy link
Author

https://iteamfox.github.io/bose_landing/

@iteamfox
Copy link
Author

Mam demo link in readme.

@iteamfox iteamfox requested a review from Zibi95 October 21, 2024 18:20
@Zibi95
Copy link

Zibi95 commented Oct 22, 2024

Okej, ale dodawaj demo link w opisie PR'a, żeby nie było problemów z sprawdzaniem.

Zibi95
Zibi95 suggested changes Oct 22, 2024
View reviewed changes
Copy link

@Zibi95 Zibi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, great job! I noticed that on screens wider than 1260px, the heading in the hero section sits lower compared to the mockup. Could you also adjust the position of the background image in the header? Once that's done, we should be good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zibi95 Zibi95 Zibi95 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iteamfox @Zibi95