Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #2663

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Develop #2663

wants to merge 19 commits into from

Conversation

Bajkowsky
Copy link

Copy link

@Zibi95 Zibi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. Check the spacing and typography again for all the devices in figma. Also there is some test
Here are some things that i found:

  • The image in hero is no centered also resolution of image is lower than expected (quality is bad)
  • This one text its weight is to high than in figma
    image
  • the image overflows text when its hovered
image
  • contact form is not centered, its aligned to left in figma
    image
  • footer image is too big lower its height
  • on mobile this image should also be centered
image
  • I know it don't have to be pixel perfect but some spacings between sections is off by tens of pixels

There is some style test that didn't pass

src/styles/blocks/reset.scss
 23:2  ✖  Unexpected shorthand "font" after "font-size"  declaration-block-no-shorthand-property-overrides

@Bajkowsky Bajkowsky requested a review from Zibi95 August 28, 2024 19:38
Copy link

@Zibi95 Zibi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the checklist for the implementation. It seems you missed point number 15: the page should not reload on form submission. You can prevent this by using event.preventDefault() (https://developer.mozilla.org/en-US/docs/Web/API/Event/preventDefault).

Upon inspecting the elements, I noticed you're using padding everywhere. Consider using the gap property in Flexbox to simplify your layout.

Additionally, the hero image is still not centered and appears to be of low resolution. Here is a link to a higher resolution version.

@Bajkowsky Bajkowsky requested a review from Zibi95 August 29, 2024 20:43
Copy link

@Zibi95 Zibi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. You are almost there

  • Form is still not aligned to the rest of sections
    image
  • footer image is still too big
  • Add a favicon
  • font size of this title is lower than on mockup
    image
  • Location-related addresses / links should open google maps in a new tab target="_blank"
  • Fix menu for small screens (if there is not enough space for all the menu items)

@Bajkowsky Bajkowsky requested a review from Zibi95 August 30, 2024 13:04
Copy link

@Zibi95 Zibi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After recent changes layout for mobile is broken.
image

@Bajkowsky Bajkowsky requested a review from Zibi95 August 31, 2024 14:30
Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • address link should open google maps in a new tab [checklist 9]
  • bike images in section compare bikes are poor quality
  • footer image should have different background-position (it's not centered)
    image

Copy link

@BogdanMaliuta BogdanMaliuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, nice work, but need to make some changes, the most of them in tablet version
change your font family for "message"
image
change content in this header according to figma
image
on tablet version change :
your background image position
image
styles here
image
image
image

Copy link

@Zibi95 Zibi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Here spacing is to big you have applied correct values with padding and additionaly have gap
    image

  • These images on tablet looks off
    image

  • In many places, the issue with spacing is that you are applying both top and bottom padding, and these values are adding up.

@Bajkowsky Bajkowsky requested a review from Zibi95 September 9, 2024 12:37
Copy link

@Zibi95 Zibi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I can finally accept this PR, but I recommend refining it a bit more. It would be great if you could enhance it with some additional JavaScript features. Since it's a portfolio project, it needs to be both polished and representative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants