-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #2663
base: master
Are you sure you want to change the base?
Develop #2663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey. Check the spacing and typography again for all the devices in figma. Also there is some test
Here are some things that i found:
- The image in hero is no centered also resolution of image is lower than expected (quality is bad)
- This one text its weight is to high than in figma
- the image overflows text when its hovered

- contact form is not centered, its aligned to left in figma
- footer image is too big lower its height
- on mobile this image should also be centered

- I know it don't have to be pixel perfect but some spacings between sections is off by tens of pixels
There is some style test that didn't pass
src/styles/blocks/reset.scss
23:2 ✖ Unexpected shorthand "font" after "font-size" declaration-block-no-shorthand-property-overrides
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the checklist for the implementation. It seems you missed point number 15: the page should not reload on form submission. You can prevent this by using event.preventDefault() (https://developer.mozilla.org/en-US/docs/Web/API/Event/preventDefault).
Upon inspecting the elements, I noticed you're using padding everywhere. Consider using the gap property in Flexbox to simplify your layout.
Additionally, the hero image is still not centered and appears to be of low resolution. Here is a link to a higher resolution version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey. You are almost there
- Form is still not aligned to the rest of sections
- footer image is still too big
- Add a favicon
- font size of this title is lower than on mockup
- Location-related addresses / links should open google maps in a new tab target="_blank"
- Fix menu for small screens (if there is not enough space for all the menu items)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- address link should open google maps in a new tab [checklist 9]
- bike images in section compare bikes are poor quality
- footer image should have different background-position (it's not centered)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I can finally accept this PR, but I recommend refining it a bit more. It would be great if you could enhance it with some additional JavaScript features. Since it's a portfolio project, it needs to be both polished and representative.
DEMO LINK