Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #2654

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Develop #2654

wants to merge 23 commits into from

Conversation

jacube1
Copy link

@jacube1 jacube1 commented Apr 16, 2024

Copy link

@BogdanMaliuta BogdanMaliuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, some things to fix:
fix header:
image
fix recomeded:
image
fix also this:
image
image
image
Also check this all things on mobile and tablet versios

Copy link

@yevhenii-pyl yevhenii-pyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid! But we still have a few things to fix:

Something is off with tablet mixin:

tablet

desc

If you use padding-bottom to position elements - stick to it, mixing padding-top AND padding-bottom is considered to be a bad practice:

p

About-us image should be fixed:
img
(maybe, try to set it as a background property for a div, not an image)

Copy link

@yevhenii-pyl yevhenii-pyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants