-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #2652
base: master
Are you sure you want to change the base?
Develop #2652
Conversation
n3di
commented
Apr 5, 2024
- DEMO LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the design perspective, it's pretty accurate. Good job! 👍
We can and should move forward :)
However, from the coding perspective there is some room for growth:
- You have columns provided at the design, why don't you use grids to position your elements?
- You tend to position elements 'just to make it work'. It works, but this is not the cleanest approach. As a common rule here, your parent (container) elements should be responsible for positioning it's children. It means, that, whenever possible, child element should never use margin | padding properties to position itself inside the container.