Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #2652

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Develop #2652

wants to merge 4 commits into from

Conversation

n3di
Copy link

@n3di n3di commented Apr 5, 2024

Copy link

@BogdanMaliuta BogdanMaliuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello here some things to fix:
Fix background image according to design
image
Fix margins here
image
Bikes starts from uppercase latter
image
fix margin here
image
change font-famly here
image
fix this background image
image
Also check your mobile and tablet version according to figma design and fix

@n3di n3di requested a review from BogdanMaliuta April 6, 2024 09:01
Copy link

@BogdanMaliuta BogdanMaliuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, fix this:
Footer Image
image
Background in tablet version
image
Fix this on mobile version

@n3di n3di requested a review from BogdanMaliuta May 20, 2024 20:49
@yevhenii-pyl
Copy link

A bit concerned with this 'rainbow'. Why don't you just add padding-top to your header container?

r

Copy link

@yevhenii-pyl yevhenii-pyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the design perspective, it's pretty accurate. Good job! 👍
We can and should move forward :)

However, from the coding perspective there is some room for growth:

  1. You have columns provided at the design, why don't you use grids to position your elements?
  2. You tend to position elements 'just to make it work'. It works, but this is not the cleanest approach. As a common rule here, your parent (container) elements should be responsible for positioning it's children. It means, that, whenever possible, child element should never use margin | padding properties to position itself inside the container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants