Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #2647

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Develop #2647

wants to merge 6 commits into from

Conversation

MelnykA
Copy link

@MelnykA MelnykA commented Mar 4, 2024

sTorba24
sTorba24 suggested changes Mar 4, 2024
View reviewed changes
Copy link

@sTorba24 sTorba24 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Lets improve it :)

  1. cards shouldn't overlap each other
    image

  2. same here
    image

  3. check submit button styles
    image

  4. form should be submittable, and reset after it

  5. add cursor pointer to all buttons

  6. here should be links

image

@MelnykA MelnykA requested a review from sTorba24 March 4, 2024 19:19
vadiimvooo
vadiimvooo suggested changes Mar 4, 2024
View reviewed changes
Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, you are almost done. A few changes required:

  1. Add validation for email field.
  2. Use attribute targer="_blank" to open links in new tab.

@MelnykA MelnykA closed this Mar 5, 2024
@MelnykA MelnykA reopened this Mar 5, 2024
@MelnykA MelnykA requested a review from vadiimvooo March 5, 2024 07:21
etojeDenys
etojeDenys approved these changes Mar 5, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image you don't need to open a new tab when the user clicks on this link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

@sTorba24 sTorba24 Awaiting requested review from sTorba24

@vadiimvooo vadiimvooo Awaiting requested review from vadiimvooo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MelnykA @sTorba24 @etojeDenys @vadiimvooo