task solution miami #2640
Open
task solution miami #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choeqq
suggested changes
Feb 13, 2024
choeqq
suggested changes
Feb 15, 2024
asakevych
suggested changes
Feb 15, 2024
src/index.html
Outdated
| @@ -3,11 +3,165 @@ | |||
| <head> | |||
| <meta charset="UTF-8"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
| <title>Miami</title> | |||
| <title>Miami Condo Kings</title> | |||
There was a problem hiding this comment.
you have museum landing so change the title
src/styles/blocks/header.scss
Outdated
Comment on lines
1
to
5
| .header { | ||
| background-color: black; | ||
| background-image: url(/src/photos/header-background.jpg); | ||
| background-repeat: no-repeat; | ||
| background-size: cover; |
src/styles/utils/fonts.scss
Outdated
| @@ -0,0 +1,42 @@ | |||
| @font-face { | |||
There was a problem hiding this comment.
this file should have name starting with _ as all of the utils -> _fonts.scss
choeqq
suggested changes
Feb 27, 2024
There was a problem hiding this comment.
Few things to adjust:
1.
On desktop menu should be on the right side of the screen
2.
image placement in this section looks weird
3. phone, address and email should be clickable
4. form shouldn't reload the page
5. footer should have 100% of page's width
6. phone icon in menu should trigger a phone call
asakevych
suggested changes
Mar 4, 2024
Closed
choeqq
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v.001
figma: https://www.figma.com/file/lSR1m42L9YwzQwzzxKwHpw/THE-MET
[DEMO LINK]: https://Kacper7001.github.io/layout_miami/