creating PR #2635
creating PR #2635
Conversation
There was a problem hiding this comment.
I still can submit empty form without any issues, which is not ideal
I want to get an error when trying to submit empty form
I think the menu items should move us to it's sections when clicked, instead of going to /#
I am not sure if you've fixed it already, maybe you'll have to redeploy
There was a problem hiding this comment.
Great job, @weswojciech! You're almost there, just a few more touches!
In the mobile version of the landing page, in this section, the image should have a bigger height as per the mock-up:
You can see, in the mockup, it says the height should be 200px; in your landing page the height is only 131px:
src/index.html
Outdated
| <input | ||
| id="name" | ||
| type="text" | ||
| placeholder="Name" | ||
| class="form__input" | ||
| required | ||
| > |
There was a problem hiding this comment.
add name attribute for your inputs, check them to show error when empty
There was a problem hiding this comment.
Isn't 'required' attribute displaying an error when empty?
No description provided.