Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MyBike. #2612

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

MyBike. #2612

wants to merge 14 commits into from

Conversation

netzelnatalia
Copy link

anastasiiavorobiova
anastasiiavorobiova suggested changes Oct 30, 2023
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! It looks awesome on different screens and I like hovers here
Screenshot 2023-10-30 at 15 42 55
Screenshot 2023-10-30 at 15 43 02
Screenshot 2023-10-30 at 15 43 09
Consider fixing validation errors
Screenshot 2023-10-30 at 15 43 49
These links should lead to different sections
Screenshot 2023-10-30 at 15 44 18
Add a proper href attribute here
Screenshot 2023-10-30 at 15 44 21
Consider adding hovers for links
Screenshot 2023-10-30 at 15 44 28
Consider removing the default border
Screenshot 2023-10-30 at 15 44 35
Consider removing the default outline for a better user experience

anastasiiavorobiova
anastasiiavorobiova suggested changes Dec 10, 2023
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Make sure to deploy your last changes
Screenshot 2023-12-10 at 16 21 44
Screenshot 2023-12-10 at 16 21 58
Not fixed from the previous review
Screenshot 2023-12-10 at 16 20 55
Consider using z-index for the menu section to prevent overlapping by mages while scrolling
Screenshot 2023-12-10 at 16 19 08
Consider fixing validation errors

@netzelnatalia netzelnatalia marked this pull request as draft December 10, 2023 14:57
@netzelnatalia netzelnatalia marked this pull request as ready for review December 10, 2023 16:26
@netzelnatalia netzelnatalia marked this pull request as draft December 11, 2023 18:21
@netzelnatalia netzelnatalia changed the title MyBike MyBike _WiP Dec 11, 2023
@netzelnatalia netzelnatalia marked this pull request as ready for review January 7, 2024 19:19
@netzelnatalia netzelnatalia changed the title MyBike _WiP MyBike. Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiiavorobiova anastasiiavorobiova anastasiiavorobiova requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@netzelnatalia @anastasiiavorobiova