-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #2592
base: master
Are you sure you want to change the base?
Develop #2592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the validator https://validator.w3.org/ to check your page and align it with standards. I will be waiting for the previous review fixes. Make sure to deploy your page
Hi, thank you for reviewing the code and for the helpful link I received ;) . I hope I have taken your suggestions into account. Please take another look at it, maybe you have some further suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I've just implemented changes. Review code again, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, it's my request to do code view. Take a look at it again, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done, please check this comment:
- Add transition to all hover effects
- Make sure to add transition style under general selector, not the one with :hover - this way transition will work smoothly both ways. (double-check if it smooth in both ways, because now it's not)
Hi, thank you for checking the code. Please proceed with further review and any additional suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done 🔥
Hi, request to check my code for the "BOSE landing" from: [DEMO LINK]
Andrzej