Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #2592

Open
wants to merge 55 commits into
base: master
Choose a base branch
from
Open

Develop #2592

wants to merge 55 commits into from

Conversation

mysolution20
Copy link

Hi, request to check my code for the "BOSE landing" from: [DEMO LINK]
Andrzej

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the validator https://validator.w3.org/ to check your page and align it with standards. I will be waiting for the previous review fixes. Make sure to deploy your page

@mysolution20
Copy link
Author

Hi, thank you for reviewing the code and for the helpful link I received ;) . I hope I have taken your suggestions into account. Please take another look at it, maybe you have some further suggestions.
Andrzej

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Need to remove the scroll when this menu is open
image
  1. Need to remove the autocomplete styles for input
image
  1. Make all these fields are required before sending
image
  1. Add hover effects for all clickable elements
image
  1. Add a transition for hover effects everywhere
image

@mysolution20
Copy link
Author

Hi, I've just implemented changes. Review code again, please.

Copy link

@nazarmatsevych nazarmatsevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Make sure to add transition style under general selector, not the one with :hover - this way transition will work smoothly both ways.

  2. Page should not reload on submit, also clear form fields on button click
    image

  3. Add some hover effects to all interactive elements
    image

@mysolution20
Copy link
Author

Hi, it's my request to do code view. Take a look at it again, please.
Andrzej

Copy link

@nazarmatsevych nazarmatsevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, please check this comment:

  1. Add transition to all hover effects
  2. Make sure to add transition style under general selector, not the one with :hover - this way transition will work smoothly both ways. (double-check if it smooth in both ways, because now it's not)

@mysolution20
Copy link
Author

Hi, thank you for checking the code. Please proceed with further review and any additional suggestions.
Andrzej

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants