Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #2590

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

Develop #2590

wants to merge 40 commits into from

Conversation

przwojwwp
Copy link

@przwojwwp przwojwwp commented Oct 9, 2023

DEMO LINK:
https://przwojwwp.github.io/layout_miami/

FIGMA LAYOT LINK:
https://www.figma.com/file/NZQAIydtHo5QkINyGLHNcq/BIKE-New-Version?type=design&node-id=0-1&mode=design&t=byUV0YqdQsu9JQJI-0

MYBIKE landing

Website for selling electric bikes

build with technology:

  • HTML
  • CSS
  • SCSS

Copy link

@Viktor-Kost Viktor-Kost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep going!)

  1. Add a favicon
  2. Add header section
  3. Apply responsive design

@przwojwwp przwojwwp requested a review from Viktor-Kost October 18, 2023 12:18
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress! You have done a lot of work! Keep doing to fix small issues here:
Screenshot 2023-10-18 at 15 47 33
Implement the responsive design for tablets
Screenshot 2023-10-18 at 15 47 11
Outline should be removed
Screenshot 2023-10-18 at 15 46 50
The button is too large for the desktop
Screenshot 2023-10-18 at 15 46 20
Screenshot 2023-10-18 at 15 46 05
Screenshot 2023-10-18 at 15 45 44
A user should be able to click on these links, so add proper href attributes here

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍
Let's improve your page

  1. The picture should be placed in the same way as on the design
    Demo
image

Design
image

  1. Need to remove the scroll when this menu is open
image
  1. Need to change the title page to 'MyBike'
image
  1. Make all these fields are required before sending
image
  1. Need to remove the autocomplete styles
image
  1. Make resize: none to the textarea
image
  1. When I click send form I get this problem
image
  1. Add hover effects for all clickable elements and here
image

…e page title, add required for form inputs, change autocomplete styles, textarea noresize
@przwojwwp
Copy link
Author

there is no specification for hover this elements sir

image

Copy link

@nazarmatsevych nazarmatsevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Page should not reload on submit, also clear form field on button click, add this to your form and don't forget to make form fields required
    image

  2. This link should open google maps read address
    image

  3. Something wrong with oveflow: hidden, please doublecheck it, when i click on burger menu items it should be removed from body
    image

  4. Add some hover effects and transition to all interactive elements
    image
    image

  5. Add scale to all images in gallery
    image

  6. Proofread your code with both of this checklists

@przwojwwp
Copy link
Author

I see that I skipped the checklist earlier. I hope everything will be fine now

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a huge progress here. The page is almost done:
Screenshot 2023-10-24 at 14 40 30
Consider fixing validation errors
Screenshot 2023-10-24 at 14 39 38
Check the background position for tablets
Screenshot 2023-10-24 at 14 38 26
A user should be able to scroll the menu in a landscape mode
Screenshot 2023-10-24 at 14 35 48
Screenshot 2023-10-24 at 14 35 59
Consider removing outlines
Screenshot 2023-10-24 at 14 34 53
There is a broken layout in the link

@przwojwwp
Copy link
Author

Outlane was removed in earlier changes.
npm run deploy wasn't.
Should be fine now.

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants