The Met lending was created #1530
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IrynaK-a
commented
Sep 22, 2022
•
IrynaK-a
commented
- DEMO LINK
ivanchuk-yurii
suggested changes
Sep 25, 2022
src/index.html
Outdated
| > | ||
| <img | ||
| src="./images/photos/3.png" | ||
| alt="First exhibition" |
src/styles/utils/_mixins.scss
Outdated
| transition: #{$_property} 0.3s; | ||
| &:hover { | ||
| #{$_property}: $_toValue; | ||
| // @mixin hover($_property, $_toValue) { |
src/styles/blocks/grid.scss
Outdated
| @for $end from $start through 12 { | ||
| @include on-tablet { | ||
| &--tablet-#{$start}-#{$end} { | ||
| grid-column: #{$start} / #{$end + 1}; |
|
Let's make the form more live:
|
TarasHoliuk
suggested changes
Sep 29, 2022
IrynaK-a
requested review from
TarasHoliuk
and removed request for
ivanchuk-yurii
liliia-livandovskaya
suggested changes
Oct 5, 2022
There was a problem hiding this comment.
Great job! There are several things to work on:
- Add the hover effect to the items in this block
IrynaK-a
requested review from
liliia-livandovskaya
and removed request for
TarasHoliuk
liliia-livandovskaya
suggested changes
Oct 7, 2022
There was a problem hiding this comment.
Great job! There are several things to work on:
- Location-related addresses / links / images should open google maps in a new tab target="_blank". Also, add hover effects on links.
-
Page should not be reloaded on the form submit
-
The speed of animations is the same throughout the landing page
I removed reloading and kept only form automatically clearing after submit and scrolling to the top of the page. |
SanyaBratashchuk
suggested changes
Oct 8, 2022
IrynaK-a
requested review from
SanyaBratashchuk
and removed request for
liliia-livandovskaya
loralevitska
suggested changes
Dec 22, 2022
IrynaK-a
requested review from
ivanchuk-yurii,
liliia-livandovskaya and
TarasHoliuk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.