solution added #694
Open
solution added #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimurHrynenko
commented
Mar 22, 2021
TimurHrynenko
commented
- DEMO LINK
- TEST REPORT LINK
VinnieJ-2k20
suggested changes
Mar 22, 2021
src/index.html
Outdated
| <h1>Universal Declaration of Human Rights</h1> | ||
| <h2>Preamble</h2> | ||
| <p> | ||
| Whereas recognition of the inherent dignity and of the equal and inalienable rights of all members of the human family is the foundation of freedom, justice and peace in the world, |
There was a problem hiding this comment.
You should manually keep lines length less than 80 symbols, so the text can be read without horizontal scroll.
Fix it here and through the document, make it like at lines 44-48
src/style.css
Outdated
Comment on lines
10
to
32
| h1 { | ||
| font-size: 17px; | ||
| font-weight: bold; | ||
| } | ||
|
|
||
| h2 { | ||
| font-size: 15px; | ||
| font-weight: normal; | ||
| padding: 1em 0; | ||
| } | ||
|
|
||
| a { | ||
| color: green; | ||
| } | ||
|
|
||
| h1, | ||
| a, | ||
| h2, | ||
| p, | ||
| ol, | ||
| li { | ||
| margin: 0; | ||
| } |
There was a problem hiding this comment.
Add styles to classes, not to tags.
VinnieJ-2k20
approved these changes
Mar 23, 2021
Comment on lines
+178
to
+182
| <a class="link" | ||
| href="https://www.ohchr.org/EN/UDHR/Documents/UDHR_Translations/eng.pdf" | ||
| > | ||
| Articles 17 to 30 | ||
| </a> |
There was a problem hiding this comment.
Tag and attributes in this case should be on separate lines.
Suggested change
| <a class="link" | |
| href="https://www.ohchr.org/EN/UDHR/Documents/UDHR_Translations/eng.pdf" | |
| > | |
| Articles 17 to 30 | |
| </a> | |
| <a | |
| class="link" | |
| href="https://www.ohchr.org/EN/UDHR/Documents/UDHR_Translations/eng.pdf" | |
| > | |
| Articles 17 to 30 | |
| </a> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.