first attempt #2207

Ann1120-ua · 2024-11-14T01:00:25Z

No description provided.

Elena-Bruyako · 2024-11-14T09:20:35Z

checklist.md

@@ -23,7 +23,7 @@ public class Main {

 #### Write informative messages in methods.
 - Use English only and make messages informative
- The message should indicate what type of `Machine` is working right now `Truck`, `Bulldozer` or `Excavator`.
+- The message should indicate what type of `core.basesyntax.Machine` is working right now `core.basesyntax.Truck`, `core.basesyntax.Bulldozer` or `core.basesyntax.Excavator`.


revert changes

Elena-Bruyako · 2024-11-14T09:20:45Z

README.md

@@ -1,9 +1,9 @@
 # jv-oop

- Create class Machine containing methods `public abstract void doWork()` and `public abstract void stopWork()`.  
- Create classes `Truck`, `Bulldozer`, and `Excavator` that will inherit from `Machine`.
+- Create class core.basesyntax.Machine containing methods `public abstract void doWork()` and `public abstract void stopWork()`.  


revert changes

Elena-Bruyako · 2024-11-14T09:21:04Z

src/test/java/core/basesyntax/Bulldozer.java

+        System.out.println("core.basesyntax.Bulldozer has stopped working.");
+    }
+}
+


remove redundant empty line

Elena-Bruyako · 2024-11-14T09:21:18Z

src/test/java/core/basesyntax/Bulldozer.java

+public class Bulldozer extends Machine {
+    @Override
+    public void doWork() {
+        System.out.println("core.basesyntax.Bulldozer has started working.");


same for all messages

Suggested change

System.out.println("core.basesyntax.Bulldozer has started working.");

System.out.println("Bulldozer has started working.");

not fixed (fix it everywhere)

Elena-Bruyako · 2024-11-14T09:21:27Z

src/test/java/core/basesyntax/Machine.java

@@ -0,0 +1,6 @@
+package core.basesyntax;
+
+abstract class Machine {


Suggested change

abstract class Machine {

public abstract class Machine {

Elena-Bruyako · 2024-11-14T09:21:49Z

src/test/java/core/basesyntax/Machine.java

+package core.basesyntax;
+
+abstract class Machine {
+        public abstract void doWork();


check tabulation

Elena-Bruyako · 2024-11-14T09:22:07Z

src/test/java/core/basesyntax/MainAppTest.java

@@ -1,5 +1,17 @@
 package core.basesyntax;

 public class MainAppTest {
+    public static void main(String[] args) {
+        Machine[] machines = new Machine[3];


3 is a magic number, create constant

corrected this

Elena-Bruyako · 2024-11-14T09:22:22Z

src/test/java/core/basesyntax/MainAppTest.java

+        machines[0] = new Truck();
+        machines[1] = new Bulldozer();
+        machines[2] = new Excavator();
+


remove redundant empty line

I tried . it does not let me remove them in intelllij idea

liliia-ponomarenko

Good job! Let’s fix a few mistakes ;)

liliia-ponomarenko · 2024-11-18T09:10:00Z

README.md

@@ -1,9 +1,9 @@
 # jv-oop

- Create class Machine containing methods `public abstract void doWork()` and `public abstract void stopWork()`.  
- Create classes `Truck`, `Bulldozer`, and `Excavator` that will inherit from `Machine`.
+- Create class core.basesyntax.Machine containing methods `public abstract void doWork()` and `public abstract void stopWork()`.  


liliia-ponomarenko · 2024-11-18T09:10:09Z

checklist.md

@@ -23,7 +23,7 @@ public class Main {

 #### Write informative messages in methods.
 - Use English only and make messages informative
- The message should indicate what type of `Machine` is working right now `Truck`, `Bulldozer` or `Excavator`.
+- The message should indicate what type of `core.basesyntax.Machine` is working right now `core.basesyntax.Truck`, `core.basesyntax.Bulldozer` or `core.basesyntax.Excavator`.


liliia-ponomarenko · 2024-11-18T09:10:36Z

src/test/java/core/basesyntax/Bulldozer.java

+public class Bulldozer extends Machine {
+    @Override
+    public void doWork() {
+        System.out.println("core.basesyntax.Bulldozer has started working.");


not fixed (fix it everywhere)

liliia-ponomarenko · 2024-11-18T09:10:56Z

src/test/java/core/basesyntax/Excavator.java

+        System.out.println("core.basesyntax.Excavator has stopped working.");
+    }
+}
+


Suggested change

Leave only one empty line

liliia-ponomarenko · 2024-11-18T09:11:09Z

src/test/java/core/basesyntax/Machine.java

+package core.basesyntax;
+
+abstract class Machine {
+        public abstract void doWork();


liliia-ponomarenko · 2024-11-18T09:12:21Z

src/test/java/core/basesyntax/MainAppTest.java

+    public static void main(String[] args) {
+        final int MACHINE_COUNT = 3;


Suggested change

public static void main(String[] args) {

final int MACHINE_COUNT = 3;

private static final int MACHINE_COUNT = 3;

public static void main(String[] args) {

Make this variable constant

sarakhmen

Please read carefully the previous mentor's comments. Not all of them are fixed

sarakhmen · 2024-11-18T21:29:12Z

src/test/java/core/basesyntax/MainAppTest.java

+        Machine[] machines = new Machine[MACHINE_COUNT];
+        machines[0] = new Truck();
+        machines[1] = new Bulldozer();
+        machines[2] = new Excavator();


it could be done in 1 line using initialization values

done ! thanks

sarakhmen · 2024-11-18T21:30:15Z

src/test/java/core/basesyntax/MainAppTest.java

@@ -1,5 +1,16 @@
 package core.basesyntax;

 public class MainAppTest {
+    private static final int MACHINE_COUNT = 3;


add empty line after this constant

no need now

liliia-ponomarenko

Good job! 👍

liliia-ponomarenko · 2024-11-19T07:44:09Z

src/test/java/core/basesyntax/Bulldozer.java

+
+    @Override
+    public void stopWork() {
+


Suggested change

Ann1120-ua added 2 commits November 13, 2024 19:43

first attempt

cfde61a

second attempt

ea5b4fb

Elena-Bruyako suggested changes Nov 14, 2024

View reviewed changes

Ann1120-ua added 3 commits November 14, 2024 11:49

third try

ad76482

4th try

50c6ed0

5th try

ac7192b

Ann1120-ua requested a review from Elena-Bruyako November 17, 2024 21:23

6th sorry

61aef2c

liliia-ponomarenko suggested changes Nov 18, 2024

View reviewed changes

Ann1120-ua added 2 commits November 18, 2024 12:59

fixed some mistakes

23882d6

fixed some mistakes 2

58545bd

Ann1120-ua requested a review from liliia-ponomarenko November 18, 2024 18:04

fixed some mistakes 4

1049212

sarakhmen suggested changes Nov 18, 2024

View reviewed changes

fixed some mistakes 5

a8734cd

Ann1120-ua requested a review from sarakhmen November 18, 2024 21:58

liliia-ponomarenko approved these changes Nov 19, 2024

View reviewed changes

src/test/java/core/basesyntax/Bulldozer.java

@Override

public void stopWork() {

Copy link

Contributor

liliia-ponomarenko Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

first attempt #2207

first attempt #2207

Ann1120-ua commented Nov 14, 2024

Elena-Bruyako Nov 14, 2024

liliia-ponomarenko Nov 18, 2024

Elena-Bruyako Nov 14, 2024

liliia-ponomarenko Nov 18, 2024

Elena-Bruyako Nov 14, 2024

Elena-Bruyako Nov 14, 2024

liliia-ponomarenko Nov 18, 2024

Elena-Bruyako Nov 14, 2024

Ann1120-ua Nov 14, 2024

Elena-Bruyako Nov 14, 2024

Ann1120-ua Nov 14, 2024

liliia-ponomarenko Nov 18, 2024

Elena-Bruyako Nov 14, 2024

Ann1120-ua Nov 14, 2024

Elena-Bruyako Nov 14, 2024

Ann1120-ua Nov 14, 2024

liliia-ponomarenko left a comment

liliia-ponomarenko Nov 18, 2024

liliia-ponomarenko Nov 18, 2024

liliia-ponomarenko Nov 18, 2024

liliia-ponomarenko Nov 18, 2024

liliia-ponomarenko Nov 18, 2024

liliia-ponomarenko Nov 18, 2024

sarakhmen left a comment

sarakhmen Nov 18, 2024

Ann1120-ua Nov 18, 2024

sarakhmen Nov 18, 2024

Ann1120-ua Nov 18, 2024

liliia-ponomarenko left a comment

liliia-ponomarenko Nov 19, 2024

	System.out.println("core.basesyntax.Bulldozer has started working.");
	System.out.println("Bulldozer has started working.");

		@@ -0,0 +1,6 @@
		package core.basesyntax;

		abstract class Machine {

		public static void main(String[] args) {
		final int MACHINE_COUNT = 3;

first attempt #2207

Are you sure you want to change the base?

first attempt #2207

Conversation

Ann1120-ua commented Nov 14, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liliia-ponomarenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sarakhmen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liliia-ponomarenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment