Solution added - #2309
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The implementation is missing a critical validation step explicitly required by the task description. The task states: "Make sure that the given string can be converted to a number and convert it." The code currently parses population values using replaceAll and unary + without any validation, which creates a risk if the HTML data is malformed. You need to add validation (using isNaN() or similar) before converting strings to numbers to ensure only valid numeric values are processed. Additionally, there's an inconsistent locale issue: the total uses 'en-US' but the average uses 'eu-US'. For consistent US-style population data formatting, both should use 'en-US'. Once you add the input validation as specified in the task requirements and fix the locale inconsistency, the implementation should meet all checklist items.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution is approved. The implementation successfully meets all requirements: it correctly parses population data from span elements with class 'population', validates numeric conversion by filtering out NaN values, calculates both total and average values with proper rounding, and formats output using thousands separators with consistent 'en-US' locale. The code properly updates the 'Calculate it!' text elements as specified. All checklist criteria pass, and the previous review's concerns about validation and locale consistency have been resolved. Great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
No description provided.