Skip to content

add task solution - #2305

Open
reddev111 wants to merge 1 commit into
mate-academy:masterfrom
reddev111:develop
Open

add task solution#2305
reddev111 wants to merge 1 commit into
mate-academy:masterfrom
reddev111:develop

Conversation

@reddev111

Copy link
Copy Markdown
- [DEMO LINK](https://reddev111.github.io/js_get_data_DOM/)

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved because it correctly implements all the core functional requirements for the task. In src/scripts/main.js, you properly query all .population spans, strip out commas, convert the text to numbers, and then compute both the total and the rounded average from that list, satisfying the parsing and calculation requirements [CHECKLIST ITEM #1, #2, #3, #4, #12]. You then replace the Calculate it! text in both .average-population and .total-population with the computed values, and format them using toLocaleString(), which matches the expected thousands separator style [CHECKLIST ITEM #5, #6, #7]. There are no apparent syntax errors, runtime issues, or logic bugs, and the behavior should be correct for the inputs described by the task. You also respect the constraint of only modifying main.js, leaving HTML and styles unchanged [CHECKLIST ITEM #8, #9].

The only remaining checklist items relate to the demo link username and guideline/lint usage, which are outside this JavaScript implementation and can be verified or adjusted in your README/workflow as needed [CHECKLIST ITEM #10, #11, #13]. Functionally, your code is solid and meets the required standards, so there are no blocking issues requiring changes. Nice work on keeping the solution clear and focused on the requirements.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants