-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow markdown in Intros and Outros as an alternate to plain text #31
base: master
Are you sure you want to change the base?
Conversation
Still need to figure out how to render plain text of the markdowns (including the FreeMarkdown field?) |
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 98.45% 98.54% +0.08%
==========================================
Files 3 3
Lines 907 959 +52
==========================================
+ Hits 893 945 +52
Misses 8 8
Partials 6 6
Continue to review full report at Codecov.
|
Thanks @ruqqq for the PR. Looks fine to me for now, but could you add/modify some examples and tests ? The goal is checking automatically with CI that Markdown is (and will be - with future changes) displayed as expected.
To answer your question, plain text version of
|
Will do so when I get some free time. Curious question: why aren't all the fields markdown enabled by default? |
@ruqqq Hmm, you're right. At first, when I created this issue, I thought I would make all fields Markdown enabled. |
All fields markdown support will be awesome. |
Hey guys, is there a reason why this still hasn't been merged ? It's a pain to only have plaintext in intros and outros :( |
I have forked this repo to: https://github.com/go-hermes/hermes I have implemented this PR here go-hermes#6 |
Should (at least partly) solve #17.