Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix container create error on unauthenticated SMTP #49

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

ananace
Copy link
Contributor

@ananace ananace commented Feb 27, 2023

If you're using an internal SMTP server which doesn't use authentication for services, then the helm chart deploys an unusable sidekiq container;

$ kubectl --namespace mastodon get pods
...
mastodon-sidekiq-all-queues-58c6b4948f-fktj6   0/1     CreateContainerConfigError   0                24s
$ kubectl --namespace get events | grep sidekiq
...
32s       Warning   Failed                   pod/mastodon-sidekiq-all-queues-58c6b4948f-fktj6    Error: couldn't find key password in Secret mastodon/mastodon-smtp

@jasonadamyoung
Copy link

jasonadamyoung commented Feb 1, 2024

Can a maintainer please merge this?

This one is a simple, low-impact change for anyone with a password, and it's definitely necessary for those without it.

I've been running with this since at least last year when @ananace submitted the PR.

Thanks!

@jasonadamyoung
Copy link

This definitely speaks to the maintenance assistance desire in #46

@timetinytim
Copy link
Contributor

Sorry for the delay! We're finally going through the chart. Getting it merged now.

@timetinytim timetinytim merged commit d6d3f42 into mastodon:main Apr 18, 2024
@ananace ananace deleted the fix-passwordless-smtp branch April 18, 2024 20:37
@jasonadamyoung
Copy link

Great, thanks for picking this up @timetinytim!

I also just circled back and read #129 as well, that's all exciting. Thanks for your work and communication, Tim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants