Fix PHP 8.4 deprecations nullable objects (#179)

massiveart · Dec 2, 2024 · 8f5a464 · 8f5a464
1 parent 57d685d
commit 8f5a464
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 4 deletions.
diff --git a/.github/workflows/test-application.yaml b/.github/workflows/test-application.yaml
@@ -82,7 +82,14 @@ jobs:
                       dependency-versions: 'highest'
                       tools: 'composer:v2'
                       php-cs-fixer: false
-                      max-phpunit-version: '8'
+
+                    - php-version: '8.4'
+                      elasticsearch-version: '7.17.19'
+                      elasticsearch-package-constraint: '~7.17.0'
+                      minimum-stability: 'dev'
+                      dependency-versions: 'highest'
+                      tools: 'composer:v2'
+                      php-cs-fixer: false
 
         services:
             elasticsearch:

diff --git a/.php_cs.dist b/.php_cs.dist
@@ -29,5 +29,6 @@ return PhpCsFixer\Config::create()
         'phpdoc_align' => ['align' => 'left'],
         'phpdoc_types_order' => false,
         'single_line_throw' => false,
+        'nullable_type_declaration_for_default_null_value' => true,
     ])
     ->setFinder($finder);
diff --git a/Command/PurgeCommand.php b/Command/PurgeCommand.php
@@ -40,7 +40,7 @@ class PurgeCommand extends Command
 
     public function __construct(
         SearchManagerInterface $searchManager,
-        QuestionHelper $questionHelper = null
+        ?QuestionHelper $questionHelper = null
     ) {
         parent::__construct(self::$defaultName);
 

diff --git a/Command/ReindexCommand.php b/Command/ReindexCommand.php
@@ -65,7 +65,7 @@ public function __construct(
         SearchManagerInterface $searchManager,
         ReindexProviderRegistry $providerRegistry,
         $env,
-        QuestionHelper $questionHelper = null
+        ?QuestionHelper $questionHelper = null
     ) {
         parent::__construct(self::$defaultName);
 

diff --git a/Search/Event/IndexRebuildEvent.php b/Search/Event/IndexRebuildEvent.php
@@ -40,7 +40,7 @@ class IndexRebuildEvent extends AbstractEvent
      * @param mixed $purge If the indexes should be purged
      * @param OutputInterface $output
      */
-    public function __construct($filter, $purge, OutputInterface $output = null)
+    public function __construct($filter, $purge, ?OutputInterface $output = null)
     {
         $this->filter = $filter;
         $this->purge = $purge;