Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP-24572 - Enabled locale #2583

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

tom-fleming
Copy link
Contributor

Description:
Enabled locale for demonstration purposes.

Jira: (Skip unless you are MA staff)
DP-24572

To Test:

  • Add steps to test this feature

Peer Review Checklist

@tom-fleming
Copy link
Contributor Author

tom-fleming commented Jul 12, 2024

Fails
🚫 Add a changelog YAML file to this PR

Generated by 🚫 dangerJS against edad1cf

@tom-fleming tom-fleming temporarily deployed to Tugboat July 12, 2024 19:28 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat July 16, 2024 04:28 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat July 23, 2024 04:27 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat July 29, 2024 14:03 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat July 29, 2024 14:30 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat July 30, 2024 04:26 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat July 30, 2024 14:27 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat July 31, 2024 17:17 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat July 31, 2024 17:27 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat August 6, 2024 04:30 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat August 6, 2024 12:17 Destroyed
@dstorozhuk
Copy link
Contributor

@tom-fleming as we discussed yesterday, with @clairesunstudio — some elements on the page will not be translatable.
For example, "OFFERED BY" referenced node, Breadcrumps. We can't translate them since if we do so, then we have to translate the entire reference node/ page to not confuse users who clicked. Let’s say a user clicked on some of the Spanish titles on the Spanish page and landed on the English page.
In that case, we have to make sure untranslatable elements on the page are wrapped in elements with lang="en" attribute so screen readers will correctly recognize them. Probably, need to use the dir="ltr", but I am not sure how it works in combination with RTL languages.

@dstorozhuk
Copy link
Contributor

One consideration is the deployment of the new translation system and interface translations simultaneously. Allowing editors to translate interfaces on live environments may not be ideal as changes will be reflected immediately, leading to partially translated pages. To prevent this, it is better to avoid live translations.
Additionally, if new elements are added in the future, editors must be notified to provide or update translations for each language.
To address this, we can establish a table that can be exported as a CSV file. This table would contain all languages and strings for translation, extracted from modules/themes as discussed in the meeting.
Access to this table would be given to language editors, allowing them to update translations as needed.
Before each release, we would export existing strings and their translations to this table using CSV. Editors would be requested to ensure all translations are up to date.
Afterward, the table would be exported back to CSV format.
During the deployment process, we would upload translations to Drupal using a method such as CSV to .po or a custom mechanism for importing translations from CSV.

@dstorozhuk
Copy link
Contributor

Also, if talking about untranslatable elements on the page (Main Menu, Help Us improve this page, Footer, Header links, etc.) - should the main menu stay untranslated? If not - we should also make it translatable, same as nodes, so it can be translated.
I think it is worth translating the menu, even if the destination page stays untranslated.

@dstorozhuk
Copy link
Contributor

In my opinion, opting for the language negotiator plugin and locale modules is the best approach for this task. It's a wise decision that aligns with my own thinking.

@tom-fleming tom-fleming temporarily deployed to Tugboat August 9, 2024 20:12 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat August 9, 2024 20:14 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat August 13, 2024 04:33 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat September 10, 2024 04:22 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat September 11, 2024 18:23 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat September 17, 2024 04:21 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat September 23, 2024 19:47 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat September 24, 2024 04:23 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat October 1, 2024 04:22 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat October 1, 2024 14:31 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat October 4, 2024 17:13 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat October 8, 2024 00:11 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat October 8, 2024 04:25 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat October 8, 2024 16:56 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat October 9, 2024 14:27 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat October 11, 2024 13:33 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat October 14, 2024 05:57 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat October 15, 2024 04:38 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat October 22, 2024 04:22 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat October 29, 2024 04:20 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat November 5, 2024 17:07 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants