-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tee): gate nodes with remote attestation #588
Draft
mudler
wants to merge
13
commits into
main
Choose a base branch
from
remote_attestation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR description is too short and seems to not fulfill PR template, please fill in |
mudler
force-pushed
the
remote_attestation
branch
3 times, most recently
from
October 11, 2024 16:55
0820e19
to
cc2c91a
Compare
This was referenced Oct 15, 2024
Signed-off-by: mudler <[email protected]>
…I endpoints Signed-off-by: mudler <[email protected]>
Signed-off-by: mudler <[email protected]>
Signed-off-by: mudler <[email protected]>
Signed-off-by: mudler <[email protected]>
Signed-off-by: mudler <[email protected]>
Signed-off-by: mudler <[email protected]>
Signed-off-by: mudler <[email protected]>
The connection gater intercepts all Dials - so if we try to verify the node here we end up in a deep recursion loop as every NewStream() will get intercepted, and open a NewStream() to verify each node. This changeset adds a mechanism to: - We let Verify the node once on the first connection and track the peer status - Track bad and good peers: once we do the handshake once, we keep the host verified for a certain amount of time. After that the cache is cleared - We hold off connections until the peer is verified Signed-off-by: mudler <[email protected]>
Signed-off-by: mudler <[email protected]>
mudler
force-pushed
the
remote_attestation
branch
from
October 17, 2024 15:43
0ccc28c
to
5358a82
Compare
Signed-off-by: mudler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several enhancements and new features, primarily focusing on enabling remote attestation and TEE (Trusted Execution Environment) support, as well as some general improvements and fixes.
At high level, it boils down to 3 things, enhancing the security posture by allowing only nodes which runs signed binary in the network:
Implementation details
Under the hood this PR makes use of the Ego framework (https://github.com/edgelesssys/ego) to enable confidential computation by writing applications that runs in TEE (Trusted Execution Environment), otherwise called "enclaves".
The Remote attestation is done during the challenging phase where a node before accepting a connection or a work request it will challenge the other party. Similarly, when getting results from workers the challenge make sure that the node is running signed binary.
A new API endpoint is exposed to unencrypt messages from the Oracle. This is coupled with the new setting to always return encrypted data with the TEE keys, to allow external software to rely on messages coming only from the signed oracle binary (as only the signed oracle binary can decrypt that data). This allows external software to make sure that data produced by the oracle code can be verified afterward.
Notes for Reviewers
This PR:
Low hanging fruit (follow-up):
Signed commits