fix: install packages for contracts in dockerfile #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotBraem
force-pushed
the
fix/dockerfile
branch
from
03a43b5
to
679f7de
Compare
elliotBraem
changed the title
elliotBraem
changed the title
|
PR description is too short and seems to not fulfill PR template, please fill in |
5 tasks
mudler
reviewed
Oct 7, 2024
mudler
reviewed
Oct 7, 2024
|
Thanks for having a look @elliotBraem ! |
Co-authored-by: Ettore Di Giacinto <[email protected]> Signed-off-by: Elliot Braem <[email protected]>
Co-authored-by: Ettore Di Giacinto <[email protected]> Signed-off-by: Elliot Braem <[email protected]>
mudler
added a commit
that referenced
this pull request
Oct 17, 2024
There was still some code reading from the filesystem instead of the embedded files in the binary. Regression introduced in #523. Fixes: #578 See also: #579 Signed-off-by: mudler <[email protected]>
1 task
mudler
added a commit
that referenced
this pull request
Oct 17, 2024
* fix(contracts): load config from embedded There was still some code reading from the filesystem instead of the embedded files in the binary. Regression introduced in #523. Fixes: #578 See also: #579 Signed-off-by: mudler <[email protected]> * chore(tests): temporarly disable Twitter tests These are going to be taken care of as part of #573 Signed-off-by: mudler <[email protected]> --------- Signed-off-by: mudler <[email protected]>
|
@elliotBraem there were leftovers from the work with #492 . Should be fixed by #602 - can you confirm? Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #578.
It looks like something broke in this change to Dockerfile and node-install. Doesn't seem we need node-install anymore either.
I'm making some assumptions based on updated docs that this is how it should be. This change gives me a running node and the faucet command executes, and able to stake.
Notes for Reviewers
Signed commits