fix: miner versioning #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR description is too short and seems to not fulfill PR template, please fill in |
|
PR description is too short and seems to not fulfill PR template, please fill in |
hide-on-bush-x
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem Statement
The get_miner_versions method in the BaseValidatorNeuron class was previously designed to call all 256 miners at once. This approach could lead to significant bandwidth issues, causing network congestion and potential timeouts due to the high volume of simultaneous requests.
Solution
To address this problem, we implemented a batching mechanism within the get_miner_versions method. Instead of querying all miners at once, the method now divides the miners into smaller batches and processes each batch sequentially. This reduces the load on the network and helps prevent bandwidth-related issues.
Changes Made
Batching Requests: The miners are divided into smaller batches based on a configurable sample_size.
Sequential Processing: Each batch is processed one after the other, ensuring that the network is not overwhelmed by too many simultaneous requests.
Notes for Reviewers
Signed commits