Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: miner validator version control #168

Merged
merged 25 commits into from
Aug 6, 2024

Conversation

grantdfoster
Copy link
Contributor

@grantdfoster grantdfoster commented Jul 31, 2024

Description

This PR fixes #167

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@grantdfoster grantdfoster linked an issue Jul 31, 2024 that may be closed by this pull request
* fix: adds versions to requirements.txt

* fix: update bittensor version

* fix: btcli
@grantdfoster grantdfoster changed the title Feat miner validator version control feat--miner-validator-version-control Jul 31, 2024
@grantdfoster grantdfoster changed the title feat--miner-validator-version-control feat: miner-validator-version-control Jul 31, 2024
@grantdfoster grantdfoster changed the title feat: miner-validator-version-control feat: miner validator version control Jul 31, 2024
@hide-on-bush-x hide-on-bush-x changed the base branch from main to feature/reward-scoring-improvements August 2, 2024 20:09
Base automatically changed from feature/reward-scoring-improvements to main August 6, 2024 19:14
@grantdfoster grantdfoster marked this pull request as ready for review August 6, 2024 19:31
@grantdfoster grantdfoster enabled auto-merge (squash) August 6, 2024 19:32
Copy link
Contributor

@hide-on-bush-x hide-on-bush-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Good job

Comment on lines +24 to +38
"""
Fetches the external IP address of the machine.

Returns:
str: The external IP address.
"""
try:
response = requests.get("https://api.ipify.org?format=json")
response.raise_for_status()
ip = response.json().get("ip")
return ip
except requests.RequestException as e:
print(f"An error occurred while fetching the external IP: {e}")
return None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its great to have utils like this, we could move this to a utils folder or similar in the future, look good for now

@grantdfoster grantdfoster merged commit f778503 into main Aug 6, 2024
3 checks passed
@grantdfoster grantdfoster deleted the feat--miner-validator-version-control branch August 6, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Miner / Validator Version Control
2 participants