generated from opentensor/bittensor-subnet-template
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: miner validator version control #168
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: adds versions to requirements.txt * fix: update bittensor version * fix: btcli
grantdfoster
changed the title
Feat miner validator version control
feat--miner-validator-version-control
Jul 31, 2024
grantdfoster
changed the title
feat--miner-validator-version-control
feat: miner-validator-version-control
Jul 31, 2024
grantdfoster
changed the title
feat: miner-validator-version-control
feat: miner validator version control
Jul 31, 2024
hide-on-bush-x
changed the base branch from
main
to
feature/reward-scoring-improvements
August 2, 2024 20:09
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Good job
Comment on lines
+24
to
+38
""" | ||
Fetches the external IP address of the machine. | ||
|
||
Returns: | ||
str: The external IP address. | ||
""" | ||
try: | ||
response = requests.get("https://api.ipify.org?format=json") | ||
response.raise_for_status() | ||
ip = response.json().get("ip") | ||
return ip | ||
except requests.RequestException as e: | ||
print(f"An error occurred while fetching the external IP: {e}") | ||
return None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its great to have utils like this, we could move this to a utils folder or similar in the future, look good for now
hide-on-bush-x
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #167
Notes for Reviewers
Signed commits