feat: miner response times #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hide-on-bush-x I was thinking we can now take your list of valid responses, and further score them based on these response times. I don't think it makes sense to consider how fast a non-valid response was, otherwise miners can send back bad data fast, and get at least some rewards, which we don't want, right? |
|
Yeah that makes sense, Ill take a look at how to achieve that |
|
Closing this pull request as this functionality has already been merged into main via the data validation PR |
auto-merge was automatically disabled
August 6, 2024 19:45
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #122. It sets up the validator forwarder to use said processing times in it's rewarding/scoring of miners. This will be used alongside data validation to provide a weighted score.
masa/validator/forwarder.pynow includes the process time for each valid response (described as latency currently). note that it's impact on a score has not been implemented yet. waiting for https://github.com/masa-finance/issues/issues/197 to be implemented, and then we can use the response time as a weighted param towards the score (perhaps data validation is 0.75 weight and response time is 0.25 weight).This PR also implements a fallback for validators when they do not find any healthy UIDs (miners) to ping. We were seeing this behavior in our remote miners and this addresses that! It also adds a helper command in the Makefile to send TAO
Notes for Reviewers
Signed commits