Use Swift Argument Parser instead of Commandant. #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgoldberg
added
the
🧽 chore
Move MasKitTests module to masTests. Rename MasKit enum as Mas. Upgrade swift-tools-version from 5.3 to 5.6.1. swift-tools-version 5.5+ is necessary to allow test code to import executable target code, to allow MasKit library code to be moved into the mas executable. Upgrade to swift-tools-version to 5.6.1 instead of to 5.5 because they support all the same macOS versions. Standardize comments. Signed-off-by: Ross Goldberg <[email protected]>
Signed-off-by: Ross Goldberg <[email protected]>
Command structs are nested types of Mas. Renamed structs. Limit code visibility as much as possible. Standardize variable names. Standardize spacing. Fix a few tests. Disable a useless test. Remove unnecessary test stdout output. Get swift-format from Brewfile instead of from Package.swift since swift-format depends on an old version of swift-argument-parser. Signed-off-by: Ross Goldberg <[email protected]>
…ve history. Signed-off-by: Ross Goldberg <[email protected]>
Throw when failure. Normal Void return when success. Signed-off-by: Ross Goldberg <[email protected]>
Resolve mas-cli#542 Signed-off-by: Ross Goldberg <[email protected]>
Resolve mas-cli#542 Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg
force-pushed
the
542-swift-argument-parser
branch
from
133fcf3 to
0efd73a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Swift Argument Parser instead of Commandant.
If reviewing on GitHub, look at individual commits instead of the full change from the branch. Many files were moved. Each individual commit moves files, instead of deleting old files & creating new files. If you look at the changes across the whole branch in GitHub, however, many old files are shown as deleted with a new file created elsewhere instead of the move being preserved, so you can't easily see the actual text changes in the files on GitHub.
Resolve #542