Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aliases #283

Closed
wants to merge 6 commits into from
Closed

Aliases #283

wants to merge 6 commits into from

Conversation

danielbayley
Copy link
Contributor

@danielbayley danielbayley commented Jun 16, 2020 •
edited
Loading

Closes #281.

@danielbayley
Add i[nstall] alias
ed755cd 
Add `i` alias for `install` command. See mas-cli#281.
@danielbayley
Add l[i]s[t] alias
8f3bd0c 
Add `ls` alias for `list` command. See mas-cli#281.
@danielbayley
Add remove alias
55d7e6e 
Add `remove` alias for `uninstall` command. See mas-cli#281.
@danielbayley
Add r[e]m[ove] alias
7f4689b 
Add `rm` alias for `uninstall` command. See mas-cli#281.
@danielbayley danielbayley mentioned this pull request Jun 16, 2020
Open
@danielbayley
Add update alias
1c736a8 
Add `update` alias for `brew upgrade mas`. See mas-cli#281.
@danielbayley danielbayley marked this pull request as draft June 16, 2020 15:53
@phatblat
Copy link
Member

I took a look at this and am worried about maintaining duplicate code. Unfortunately with Swift's structs` there's no inheritance, so need to look at other ways to reuse code.

I started a change to Commandant for alias support Carthage/Commandant#155

@danielbayley danielbayley marked this pull request as ready for review October 16, 2020 21:59
@danielbayley
Copy link
Contributor Author

I took a look at this and am worried about maintaining duplicate code.

@phatblat Yeah, this workaround is obviously very far from ideal.

Unfortunately with Swift's structs` there's no inheritance, so need to look at other ways to reuse code.

Not a fan of inheritance anyway… But as @rgoldberg pointed out, there is now Swift Argument Parser available, so fully migrating to that would likely be best…

@rgoldberg
Copy link
Contributor

rgoldberg commented Oct 14, 2024 •
edited
Loading

mas has migrated from Commandant to Apple's Swift Argument Parser. The latter supports aliases. Will make a new PR.

@rgoldberg rgoldberg closed this Oct 14, 2024
@danielbayley danielbayley deleted the aliases branch October 15, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🆕 feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subcommand aliases
3 participants
@danielbayley @phatblat @rgoldberg