fix: change substr() to substring() #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/index.js
Outdated
| @@ -19,12 +19,12 @@ const isDataOption = str => isMatchingOption(['--data ', '--data-ascii ', '-d ', | |||
| const removeLeadingTrailingQuotes = (str) => { | |||
| const quotes = ['\'', '"']; | |||
| const newStr = str.trim(); | |||
| return quotes.includes(newStr[0]) ? newStr.substr(1, newStr.length - 2) : newStr; | |||
| return quotes.includes(newStr[0]) ? newStr.substring(1, newStr.length - 2) : newStr; | |||
There was a problem hiding this comment.
substr's second parameter is length based. substring's is offset based.
This means that if the first parameter is 0 then there is no difference when converting but in this case it's 1 which can't be converted by just replacing the function name.
The right code in this case would be
newStr.substring(1, newStr.length - 1)
There was a problem hiding this comment.
Thanks for reviewing! I added your suggestion in the latest commit.
There was a problem hiding this comment.
Circling back here -- ok to merge?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been reading your code, thank you for it! 😄
I noticed that it uses
substr()which has been deprecated.I updated with
substring()which should be an adequate replacement if you agree.I didn't notice any ways set up to write tests in the repo, but I'd be happy to provide some if needed.
This PR includes:
src/index.js.