Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SASL on libera.chat #572

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iglosiggio
Copy link

While deploying an IRC bot to libera.chat (w/@Lartu) we were unable to connect via SASL because the ACK was never recognized.

The reason for that rested on a check that expected a weird leftover space character.

This PR checks that a trimmed version of the third argument is equal to sasl.

This is enough for our personal purposes but i'm not sure if it is a proper fix.

While deploying a bot to libera.chat we were unable to connect via SASL because the ACK was never recognized. The reason for that rested on this weird space.

This patch checks that a trimmed version of the second argument is equal to `sasl`. This is enough for our personal purposes.
@ralyodio
Copy link

Pretty sure this project is dead. Its' been literally a year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants