ui: refactor prompt to write to stdout or stderr #4536
+22
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuja
reviewed
Sep 25, 2024
| buf = trimmed.to_owned(); | ||
| } else if buf.is_empty() { | ||
| return Err(io::Error::new( | ||
| let buf = buf.strip_suffix('\n').map(|s| s.to_owned()).unwrap_or(buf); |
There was a problem hiding this comment.
nit: buf.truncate(trimmed.len()) could also be used.
btw, if buf == "\n", an empty string should be returned. It's not an EOF.
| @@ -566,15 +566,15 @@ impl Ui { | |||
| .unwrap_or(false) | |||
| } | |||
|
|
|||
| pub fn prompt(&self, prompt: &str) -> io::Result<String> { | |||
| pub fn prompt(&self, writer: &mut dyn Write, prompt: &str) -> io::Result<String> { | |||
| if !Self::can_prompt() { | |||
There was a problem hiding this comment.
Can you elaborate the intent? It's weird that can_prompt() tests stdout, but we use an arbitrary write stream.
If the goal was to handle the case where stdout is redirected, it might be okay to always use stderr. Maybe we can also use some library that can obtain tty even if stdout/err was redirected. I assume rpassword does something like that.
There was a problem hiding this comment.
I assume its for testing Google's custom binary. But I agree that its missing the intent in the commit message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md