Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revset, templater: add deprecation warnings #4515

Merged
merged 6 commits into from
Sep 22, 2024
Merged

revset, templater: add deprecation warnings #4515

merged 6 commits into from
Sep 22, 2024

Commits on Sep 22, 2024

  1. dsl_util: add basic diagnostics receiver 

    This object will be passed around AST processing functions. It's basically a
Vec<ParseError>.
    @yuja
    yuja committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    4d6b018 View commit details
    Browse the repository at this point in the history

  2. revset, templater: make context message of nested errors less specific 

    So that these error variants can be reused as warning contexts.
    @yuja
    yuja committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    867d636 View commit details
    Browse the repository at this point in the history

  3. fileset: pass diagnostics receiver around, add printing function 

    CLI tests will be added later.
    @yuja
    yuja committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    0e885c0 View commit details
    Browse the repository at this point in the history

  4. revset: pass diagnostics receiver around 

    Stacking at AliasExpanded node looks wonky. If we migrate error handling to
Diagnostics API, it might make sense to remove AliasExpanded node and add
node.aliases: vec![(id, span), ..] field instead.

Some closure arguments are inlined in order to help type inference.
    @yuja
    yuja committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    fbea710 View commit details
    Browse the repository at this point in the history

  5. templater: pass diagnostics receiver around

    @yuja
    yuja committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    ca32cc2 View commit details
    Browse the repository at this point in the history

  6. revset, templater: add deprecation warnings

    @yuja
    yuja committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    1dd88d7 View commit details
    Browse the repository at this point in the history