Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: create jj file list and deprecate jj files #3902

Merged
merged 1 commit into from
Jun 17, 2024
Merged

cli: create jj file list and deprecate jj files #3902

merged 1 commit into from
Jun 17, 2024
+46 −21

Conversation

fowles
Copy link
Collaborator

@fowles fowles commented Jun 17, 2024 •
edited
Loading

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

PhilipMetzger
PhilipMetzger requested changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is mostly LG by itself, I'm going to block on the whole aliasing discussion. And I would prefer if you'd used the cli: prefix to make the affected component visible.

cli/src/commands/file/mod.rs Outdated Show resolved Hide resolved
cli/src/commands/mod.rs Show resolved Hide resolved
@fowles fowles changed the title feat: create jj file list and deprecate jj files cli: create jj file list and deprecate jj files Jun 17, 2024
@fowles fowles enabled auto-merge (rebase) June 17, 2024 18:08
@fowles fowles merged commit 5d307e6 into martinvonz:main Jun 17, 2024
17 checks passed
@fowles fowles deleted the file_list branch June 17, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipMetzger PhilipMetzger PhilipMetzger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fowles @PhilipMetzger