Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential deadlock #668

Merged
merged 2 commits into from
May 19, 2024
Merged

Fix potential deadlock #668

merged 2 commits into from
May 19, 2024

Conversation

martincostello
Copy link
Owner

@martincostello martincostello commented May 19, 2024

  • Fix a potential deadlock where the server never stops by checking the result of WaitToReadAsync() and by passing the CancellationToken to ReadAsync().
  • Give the server as long as it needs to start in tests/examples, then cancel after started.

Fix a potential deadlock where the server never stops by checking the result of `WaitToReadAsync()` and by passing the `CancellationToken` to `ReadAsync()`.
@martincostello martincostello added enhancement New feature or request .NET Pull requests that update .net code labels May 19, 2024
@martincostello martincostello added this to the v0.8.1 milestone May 19, 2024
Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.56%. Comparing base (68ae617) to head (4647513).

Files Patch % Lines
src/AwsLambdaTestServer/RuntimeHandler.cs 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #668   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files           8        8           
  Lines         287      288    +1     
  Branches       30       31    +1     
=======================================
+ Hits          280      281    +1     
+ Misses          3        2    -1     
- Partials        4        5    +1     
Flag Coverage Δ
linux 96.87% <33.33%> (-0.69%) ⬇️
macos 96.87% <33.33%> (+0.01%) ⬆️
windows 97.56% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello marked this pull request as draft May 19, 2024 16:11
Give the server as long as it needs to start, then cancel after started.
@martincostello martincostello marked this pull request as ready for review May 19, 2024 16:28
@martincostello martincostello merged commit d22786a into main May 19, 2024
11 of 12 checks passed
@martincostello martincostello deleted the check-result branch May 19, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant