Update to .NET 8 #403
Merged
Update to .NET 8 #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martincostello
added
enhancement
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
- Coverage 98.58% 98.25% -0.33%
==========================================
Files 8 8
Lines 283 287 +4
Branches 29 30 +1
==========================================
+ Hits 279 282 +3
Misses 1 1
- Partials 3 4 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martincostello
force-pushed
the
dotnet-vnext
branch
2 times, most recently
from
3d9e7be
to
3c890b3
Compare
martincostello
added a commit
that referenced
this pull request
May 17, 2023
Cherry-pick various changes from #403.
Merged
martincostello
added a commit
that referenced
this pull request
May 17, 2023
Cherry-pick various changes from #403.
martincostello
force-pushed
the
dotnet-vnext
branch
2 times, most recently
from
9e8eefa
to
80c81cc
Compare
martincostello
force-pushed
the
dotnet-vnext
branch
from
2cb6b7d
to
b7df773
Compare
martincostello
added a commit
that referenced
this pull request
Jun 16, 2023
Cherry-pick change from #403 to suppress CA1861 in tests.
Merged
martincostello
added a commit
that referenced
this pull request
Jun 16, 2023
Cherry-pick change from #403 to suppress CA1861 in tests.
martincostello
force-pushed
the
dotnet-vnext
branch
3 times, most recently
from
7c1bfb4
to
27f9693
Compare
martincostello
force-pushed
the
dotnet-vnext
branch
from
27f9693
to
feb7e0c
Compare
martincostello
force-pushed
the
dotnet-vnext
branch
5 times, most recently
from
7c018eb
to
ad834b1
Compare
martincostello
force-pushed
the
dotnet-vnext
branch
from
ad834b1
to
e5571cc
Compare
martincostello
force-pushed
the
dotnet-vnext
branch
4 times, most recently
from
c6e2221
to
0267798
Compare
Update NuGet packages for RC.1.
Update .NET SDK to version 8.0.100-rc.1.23463.5. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <[email protected]>
- Use primary constructors where relevant. - Use collection literals where relevant. - Remove some redundant suppressions. - Apply some IDE suggestions.
Simplify test by using `Parallel.ForAsnc()`.
Update .NET SDK to version 8.0.100-rc.2.23502.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <[email protected]>
Update NuGet packages for RC2.
Update comment with changes in behaviour for .NET 8 in Amazon.Lambda.RuntimeSupport.
Add new `DisableMemoryLimitCheck` property for .NET 8 that sets the `AWS_LAMBDA_DOTNET_DISABLE_MEMORY_LIMIT_CHECK` environment variable to `true`. See aws/aws-lambda-dotnet#1595.
Bump version to 0.8.0.
Fix copy-pasta setting the wrong environment variable.
Add a test that checks whether memory limits are enforced.
Add a unit test to validate that memory limits are not enforced if `DisableMemoryLimitCheck = true`. This needs to be set in isolation as the underlying setting is process-wide and can only be set once.
It appears that changing the garbage collector's limits doesn't work on macOS.
Use `bool.TrueString` as it's only ever set to `true` anyway.
Fix-up the tests for the memory limits enforced by Lambda so that they properly test the scenario and also aren't flaky when run in combination with other tests.
Fix skip not applying to `[InlineData]`.
Apply fixe after rebasing to pick up changes from #526.
- Remove redundant additional code. - Fix timeout being too long, left over from debugging.
Enable the test for disabling memory limits after #528.
See if the test behaves correctly on macOS.
Still doesn't seem to apply the memory limit.
Use the new MSBuild terminal logger.
Add workaround for xunit/xunit#2812.
martincostello
force-pushed
the
dotnet-vnext
branch
from
3883843
to
de2b741
Compare
Update .NET SDK to version 8.0.100. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <[email protected]>
Use stable versions of NuGet packages for .NET 8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net8.0target framework support.LambdaTestServerOptions.DisableMemoryLimitCheckoption fornet8.0.UseArtifactsOutput=trueinstead of explicitly setting the output path, as well as dropping explicit use of--configurationnow that the default isRelease.