optional dst_dir in CWSRecorder with default in settings

netatmo_geopy/core.py

@@ -276,8 +276,8 @@ def __init__(
         lat_sw,
         lon_ne,
         lat_ne,
-        dst_dir,
         *,
+        dst_dir=None,
         client_id=None,
         client_secret=None,
         username=None,
@@ -298,8 +298,10 @@ def __init__(
         ----------
         lon_sw, lat_sw, lon_ne, lat_ne : numeric
             Latitude/longitude coordinates of the bounds of the region of interest
-        dst_dir : str or pathlib.Path object
-            Path to the directory where the recorded snapshots are to be dumped.
+        dst_dir : str or pathlib.Path object, optional
+            Path to the directory where the recorded snapshots are to be dumped. Only
+            used when the `dump_snapshot_gdf` method is called, ignored otherwise. If
+            None, the default value from `settings.DEAFULT_DST_DIR`.
         client_id, client_secret, username, password : str, optional
             Authentication credentials for Netatmo. If None, the respective values set
             in the "NETATMO_CLIENT_ID", "NETATMO_CLIENT_SECRET", "NETATMO_USERNAME" and

netatmo_geopy/settings.py

@@ -7,6 +7,7 @@
 PUBLIC_DATA_URL = f"{BASE_URL}/api/getpublicdata"
 
 # recording/IO
+DEFAULT_DST_DIR = "./snapshot-data"
 DEFAULT_DATETIME_FORMAT = "%Y-%m-%dT%H:%M"
 DEFAULT_SNAPSHOT_FILE_EXT = "gpkg"
 DEFAULT_SAVE_RESPONSES = False

tests/test_netatmo_geopy.py

@@ -5,9 +5,10 @@
 import logging as lg
 import time
 
-import netatmo_geopy as nat
 import numpy as np
 import pytest
+
+import netatmo_geopy as nat
 from netatmo_geopy import settings, utils
 
 
@@ -34,7 +35,7 @@ def test_core(requests_mock, datadir, shared_datadir, mock_auth):
         2,
         3,
         4,
-        datadir,
+        dst_dir=datadir,
         client_id="abcd",
         client_secret="abcd",
         username="john",