Remove ordered class Meta option #2704
Conversation
There was a problem hiding this comment.
Nice cleanup!
Should we add a test where OrderedDict is used as dict_class?
We may want to rename schema classes in test_options as they don't make much sense when everything schema is ordered. This is something I should have done in #1896 but I lazily postponed. It can wait a little more...
CHANGELOG.rst
Outdated
| @@ -35,6 +35,9 @@ As a consequence of this change: | |||
|
|
|||
| Thanks :user:`ddelange` for the PR. | |||
|
|
|||
| - The `ordered` class Meta option is removed. Set `Schema.dict_class` to `OrderedDict` to maintain the previous behavior. | |||
| Note that field order already preserved by default (:issue:`2146`). | |||
There was a problem hiding this comment.
s/field order already preserved/field order is already preserved
looks like we already have one here marshmallow/tests/test_schema.py Lines 2663 to 2664 in 747c198
good idea. done |
close #2146