Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle postgres arrays of Enums multidimensional arrays #654

Merged
merged 5 commits into from
Jan 19, 2025
Merged

Conversation

sloria
Copy link
Member

@sloria sloria commented Jan 19, 2025

fixes #653

credit goes to @carterjc for detailing the fix in the issue 🙇

@sloria sloria merged commit d42a076 into dev Jan 19, 2025
10 of 11 checks passed
@sloria sloria deleted the bug branch January 19, 2025 05:07
@carterjc
Copy link

@sloria thanks for fixing the issue! sorry i wasn't able to PR, was just traveling and didn't get around to it.

I like how you modified _get_field_class_for_data_type instead of my hack in the array_factory, good to know

@sloria
Copy link
Member Author

sloria commented Jan 20, 2025

the _get_field_class_for_data_type was just a readability improvement. the actual fix was in the array and enum factories, which you correctly identified 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugs with enums, (PG) arrays of enums, and (PG) multidimensional arrays
2 participants