Skip to content

Commit

Permalink
Merge branch 'v1.1.5.1' into 'main'
Browse files Browse the repository at this point in the history
Bugfix Release

See merge request wmarshall/SecretManagement.Warden!20
  • Loading branch information
marshallwp committed Sep 25, 2024
2 parents db8c07d + eab1a17 commit bbb0a44
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 20 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@{
ModuleVersion = '1.1.5'
ModuleVersion = '1.1.5.1'
RootModule = 'SecretManagement.Warden.Extension.psm1'
FunctionsToExport = @(
'Get-Secret',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ function Invoke-BitwardenCLI {
}
process {
$ps = New-Object System.Diagnostics.Process
$ps.StartInfo.Filename = $BitwardenCLI
$ps.StartInfo.Filename = $BitwardenCLI.Source

$args | ForEach-Object {
Write-Verbose "Argument: $_"
Expand Down
4 changes: 2 additions & 2 deletions SecretManagement.Warden.Extension/private/Test-CLIVersion.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function Test-CLIVersion {
[ValidateScript({
if($_.PSTypeNames -match '^(?:Deserialized\.)?System\.Management\.Automation\.CommandInfo$')
{ return $true }
else { throw "Cannot convert the `"$_`" value of type `"$iptType`" to type `"System.Management.Automation.ApplicationInfo`"." }
else { throw "Cannot convert the `"$_`" value of type `"$iptType`" to type `"System.Management.Automation.CommandInfo`"." }
})]
[PSObject]$BitwardenCLI,
# Minimum Supported Version of the Bitwarden CLI.
Expand Down Expand Up @@ -85,7 +85,7 @@ function Test-CLIVersion {
$Warnings = DATA {@{
WarnOutdated = "Your bitwarden-cli is version {0} and is out of date. Please upgrade to at least version {1}."
WarnSpecificVersion = "Your bitwarden-cli is version {0}. This version of the CLI has a known issue affecting [{1}], which is used by [{2}]."
WarnVersionRange = "Your bitwarden-cli is version {0}. Versions {1} {2} of the CLI have a known issue affecting [{3}], which is used by [{4}]."
WarnVersionRange = "Your bitwarden-cli is version {0}. Versions {1} - {2} of the CLI have a known issue affecting [{3}], which is used by [{4}]."
See = "See: {0}."
StrongAction = "It is `e[3mstrongly`e[23m recommended that you move to another version."
}}
Expand Down
20 changes: 4 additions & 16 deletions SecretManagement.Warden.psd1
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# RootModule = ''

# Version number of this module.
ModuleVersion = '1.1.5'
ModuleVersion = '1.1.5.1'

# Supported PSEditions
CompatiblePSEditions = @("Core")
Expand Down Expand Up @@ -101,21 +101,9 @@
IconUri = 'https://raw.githubusercontent.com/marshallwp/SecretManagement.Warden/main/images/warden_extension_logo_85x85.png'

# ReleaseNotes of this module
ReleaseNotes = "## Code Changes
- Moved version checks to the new Test-CLIVersion function so it can be tested.
- Warnings are now localized to: Czech, German, Greek, French, and Spanish via machine translation.
Files at: 'SecretManagement.Warden.Extension\private\localization\<ISO639-code>\Test-CLIVersion.psd1'
## Testing
- GitHub workflow folder renamed from workflow to workflow*s*. 🤦🏻‍♂️
- Limited code coverage to Linux runs to avoid clutter.
- Testing added for Test-CLIVersion.ps1.
- Testing for querying the various package managers is included where they're faster.
- Testing for querying `bw` directly included for both directly specified instances and other package managers.
## Documentation
- Corrected code comments and help for ConvertTo-Hashtable.
- Added PSScriptAnalyzer badge to README.md.
- Improved badge styling consistency.
- Tweaked the Dependencies portion of the README to be more concise and include Homebrew."
ReleaseNotes = "## Bugfix
- Invoke-BitwardenCLI now correctly uses the entire filePath when refering to explicitly specified CLIs instead of just the name.
- Error text for Test-CLIVersion Parameter Validation on BitwardenCLI now refers to the correct datatype."

# Prerelease string of this module
# Prerelease = ''
Expand Down

0 comments on commit bbb0a44

Please sign in to comment.