Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Fix compilation on python3.10, correct workflow file for python3.10, fix pre-commit-config.yaml + github CI #29

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Commits on Jan 24, 2024

  1. Configuration menu
    Copy the full SHA
    fe7c713 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eead56c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    134d3c3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c849975 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    87a2f82 View commit details
    Browse the repository at this point in the history
  6. Depende on importlib_metadata instead of importlib.metadata

    This solves the following issue:
    
    ```
    TypeError: entry_points() got an unexpected keyword argument 'group'
    ```
    
    This comes due to an old implementation of `importlib` and specifically
    when I'm running my app inside a virtual environment. Attempts to `pip3
    install --force-reinstall importlib`, inside the virtualenv, did not
    work since it seems that `importlib` is brought from the standard python
    distribution regardless of whether the environment is sourced or not. To
    accommodate running the app inside and outside a virtualenv I'm instead
    depending on `importlib_metadata` which seems to resolve the
    aforementioned issue.
    nikoskoukis-slamcore committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    c29d019 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Configuration menu
    Copy the full SHA
    53f87ef View commit details
    Browse the repository at this point in the history