Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused config #910

Open
wants to merge 2 commits into
base: mainline
Choose a base branch
from
Open

Remove unused config #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3aa9dce
Remove unused config
farshidz Jul 17, 2024
d5791a4
Merge remote-tracking branch 'origin/mainline' into farshid/remove-un…
farshidz Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/marqo/api/configs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ def default_env_vars() -> dict:
EnvVars.VESPA_DELETE_POOL_SIZE: 10,
EnvVars.VESPA_PARTIAL_UPDATE_POOL_SIZE: 10,
EnvVars.VESPA_SEARCH_TIMEOUT_MS: 1000,
EnvVars.MARQO_MAX_INDEX_FIELDS: None,
EnvVars.MARQO_MAX_DOC_BYTES: 100000,
EnvVars.MARQO_MAX_RETRIEVABLE_DOCS: 10000,
EnvVars.MARQO_MAX_SEARCH_LIMIT: 1000,
Expand Down
3 changes: 0 additions & 3 deletions src/marqo/tensor_search/enums.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ class EnvVars:
VESPA_GET_POOL_SIZE = "VESPA_GET_POOL_SIZE"
VESPA_DELETE_POOL_SIZE = "VESPA_DELETE_POOL_SIZE"
VESPA_PARTIAL_UPDATE_POOL_SIZE = "VESPA_PARTIAL_UPDATE_POOL_SIZE"
MARQO_MAX_INDEX_FIELDS = "MARQO_MAX_INDEX_FIELDS"
MARQO_MAX_DOC_BYTES = "MARQO_MAX_DOC_BYTES"
MARQO_MAX_RETRIEVABLE_DOCS = "MARQO_MAX_RETRIEVABLE_DOCS"
MARQO_MAX_SEARCH_LIMIT = "MARQO_MAX_SEARCH_LIMIT"
Expand All @@ -63,11 +62,9 @@ class EnvVars:
MARQO_ROOT_PATH = "MARQO_ROOT_PATH"
MARQO_MAX_CPU_MODEL_MEMORY = "MARQO_MAX_CPU_MODEL_MEMORY"
MARQO_MAX_CUDA_MODEL_MEMORY = "MARQO_MAX_CUDA_MODEL_MEMORY"
MARQO_EF_CONSTRUCTION_MAX_VALUE = "MARQO_EF_CONSTRUCTION_MAX_VALUE"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the corresponding env var in config.py also deleted? same to MARQO_MAX_NUMBER_OF_REPLICAS

MARQO_MAX_VECTORISE_BATCH_SIZE = "MARQO_MAX_VECTORISE_BATCH_SIZE"
MARQO_MAX_SEARCHABLE_TENSOR_ATTRIBUTES = "MARQO_MAX_SEARCHABLE_TENSOR_ATTRIBUTES"
MARQO_MAX_DELETE_DOCS_COUNT = "MARQO_MAX_DELETE_DOCS_COUNT"
MARQO_MAX_NUMBER_OF_REPLICAS = "MARQO_MAX_NUMBER_OF_REPLICAS"
MARQO_DEFAULT_EF_SEARCH = "MARQO_DEFAULT_EF_SEARCH"
MARQO_BEST_AVAILABLE_DEVICE = "MARQO_BEST_AVAILABLE_DEVICE"
MARQO_ENABLE_BATCH_APIS = "MARQO_ENABLE_BATCH_APIS"
Expand Down
Loading