Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the new inference API #1142

Merged
merged 5 commits into from
Mar 13, 2025
Merged

Define the new inference API #1142

merged 5 commits into from
Mar 13, 2025

Conversation

papa99do
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature

  • What is the current behavior? (You can also link to an open issue here)
    no consolidated inference API

  • What is the new behavior (if this is a feature change)?
    provide a simple and consolidated inference API so we can have multiple implementations

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    No, just the API is provided, not implementation

  • Related Python client changes (link commit/PR here)
    No

  • Related documentation changes (link commit/PR here)
    No

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@papa99do papa99do temporarily deployed to marqo-test-suite March 11, 2025 05:01 — with GitHub Actions Inactive
@papa99do papa99do requested review from farshidz and wanliAlex March 11, 2025 05:02
@papa99do papa99do temporarily deployed to marqo-test-suite March 11, 2025 05:02 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 11, 2025 05:03 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 11, 2025 05:03 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 11, 2025 05:03 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 11, 2025 05:03 — with GitHub Actions Inactive
Copy link
Collaborator

@farshidz farshidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have unit test coverage for these? The pydantic models are testable

@papa99do papa99do temporarily deployed to marqo-test-suite March 11, 2025 10:20 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 11, 2025 10:21 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 11, 2025 10:22 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 11, 2025 10:22 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 11, 2025 10:22 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 11, 2025 10:22 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 11, 2025 10:36 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 11, 2025 11:40 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 11, 2025 11:40 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 12, 2025 03:59 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 12, 2025 04:00 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 12, 2025 04:01 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 12, 2025 04:01 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 12, 2025 04:01 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 12, 2025 04:01 — with GitHub Actions Inactive
@papa99do papa99do requested a review from farshidz March 12, 2025 04:06
@papa99do papa99do temporarily deployed to marqo-test-suite March 12, 2025 04:11 — with GitHub Actions Inactive
Copy link
Collaborator

@wanliAlex wanliAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@papa99do papa99do temporarily deployed to marqo-test-suite March 12, 2025 22:49 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 12, 2025 22:51 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 12, 2025 22:51 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 12, 2025 22:51 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 12, 2025 22:51 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 12, 2025 22:51 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 12, 2025 22:51 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite March 13, 2025 00:00 — with GitHub Actions Inactive
@papa99do papa99do merged commit d9329b3 into mainline Mar 13, 2025
31 checks passed
@papa99do papa99do deleted the yihan/mw-refactoring-3 branch March 13, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants