update joplin version

marph91 · Oct 1, 2023 · cc3d1f4 · cc3d1f4
1 parent 6d63f99
commit cc3d1f4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -7,7 +7,7 @@ Python interface for the [Joplin data API](https://joplinapp.org/api/references/
 [![tests](https://github.com/marph91/joppy/actions/workflows/tests.yml/badge.svg)](https://github.com/marph91/joppy/actions/workflows/tests.yml)
 [![codecov](https://codecov.io/gh/marph91/joppy/branch/master/graph/badge.svg?token=97E6IX792A)](https://codecov.io/gh/marph91/joppy)
 
-[![https://img.shields.io/badge/Joplin-2.10.17-blueviolet](https://img.shields.io/badge/Joplin-2.10.17-blueviolet)](https://github.com/laurent22/joplin)
+[![https://img.shields.io/badge/Joplin-2.12.18-blueviolet](https://img.shields.io/badge/Joplin-2.12.18-blueviolet)](https://github.com/laurent22/joplin)
 [![Python version](https://img.shields.io/pypi/pyversions/joppy.svg)](https://pypi.python.org/pypi/joppy/)
 
 ## :computer: Installation

diff --git a/test/setup_joplin.py b/test/setup_joplin.py
@@ -19,7 +19,7 @@ def download_joplin(destination: str) -> None:
         #    "https://api.github.com/repos/laurent22/joplin/releases"
         # )
         # latest_version = response.json()[0]["name"].lstrip("v")
-        latest_version = "2.10.17"
+        latest_version = "2.12.18"
         print(f"Testing with Joplin version {latest_version}.")
 
         # download the binary

diff --git a/test/test_api.py b/test/test_api.py
@@ -324,8 +324,7 @@ def test_get_notebook(self):
         """Get a specific notebook."""
         id_ = self.api.add_notebook()
         notebook = self.api.get_notebook(id_=id_)
-        # TODO: properties instead of default_properties
-        self.assertEqual(notebook.assigned_fields(), notebook.fields())
+        self.assertEqual(notebook.assigned_fields(), notebook.default_fields())
         self.assertEqual(notebook.type_, dt.ItemType.FOLDER)
 
     def test_get_notebooks(self):