-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggested changes for CUDA build #209
Conversation
- Updated cuda-ubuntu Dockerfile to use NVIDIAs CUDA image instead - Updated cuda-ubuntu Dockerfile to build NVIDIAs deviceQuery for automatic compute capability detection - Updated build-ffmpeg to use automatic compute capability - Added libzmq to build-ffmpeg
Hi Xosrov, Thank you for the pull request. Currently the integration tests fail with the following error message: It should be possible to build the image without an active Nvidia graphics card. Some people need to built the image on a different machine than where the image is later used. Please update your pull request to pass the integration tests. Then I can merge the changes back to the master branch. |
Hey Markus, your concerns are valid. I will have to add default values as fallback to prevent build failures. |
All important changes: - Updated README - Added "-O2" build option to nvccflags - Make use of CURRENT_PACKAGE_VERSION more to reduce redundancies
This was done to avoid superfluous checks for cuda compute capability, even though they are not needed
@markus-perl I've added the default values, but also made some changes to the overall build script. Please run the workflow and let me know what you think. EDIT: I've updated the original pull request text with more details about the changes |
@markus-perl The CI problems are fixed. For the CUDA Dockerfile, the problem was in the naming of the libraries. For example changing Please take a look and let me know what you think. Thanks for the amazing project! |
Thx for the work. I will merge the changes into the master branch. |
These changes were made mostly because the CUDA Dockerfile in the project, while successfully building FFmpeg, didn't recognize
nvenc
for me. I made some changes that made it work.Main Changes:
deviceQuery
from CUDA Samples incuda-ubuntu.dockerfile
so compute capability can be detected automatically. Default values are still hard-coded inside the build script, and can be overridden by setting theCUDA_COMPUTE_CAPABILITY
env variable.CURRENT_PACKAGE_VERSION
more so as to reduce redundancy.nvccflags
. Since NVIDIA's own examples do this, I don't think anything is going to break.Other Changes:
libzmq
supportlibsdl
(It's not working for me for some reason) to use SDL's Github release page insteadzlib
, for the same reason, to use Madler's Github release page insteadThe final image containing the binary is still around 650MB.