Fix bullet rendering #3804
+202
−25
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| /* Markdown Table Styles */ | ||
| .markdown-table { | ||
| border-collapse: collapse; | ||
| width: 100%; | ||
| margin: 1em 0; | ||
| font-size: 14px; | ||
| box-shadow: 0 2px 8px rgba(0, 0, 0, 0.1); | ||
| border-radius: 8px; | ||
| overflow: hidden; | ||
| } | ||
|
|
||
| .markdown-table th { | ||
| background: linear-gradient(135deg, #4a90e2 0%, #357abd 100%); | ||
| color: white; | ||
| font-weight: bold; | ||
| text-align: center; | ||
| padding: 12px 8px; | ||
| border: none; | ||
| } | ||
|
|
||
| .markdown-table td { | ||
| padding: 12px 8px; | ||
| text-align: center; | ||
| border: 1px solid #e0e0e0; | ||
| } | ||
|
|
||
| .markdown-table tr:nth-child(even) { | ||
| background-color: #f8f9fa; | ||
| } | ||
|
|
||
| .markdown-table tr:nth-child(odd) { | ||
| background-color: #ffffff; | ||
| } | ||
|
|
||
| .markdown-table tr:hover { | ||
| background-color: #e3f2fd; | ||
| transition: background-color 0.2s ease; | ||
| } | ||
|
|
||
| .markdown-table tbody tr:last-child td { | ||
| border-bottom: none; | ||
| } | ||
|
|
||
| /* Responsive Design */ | ||
| @media (max-width: 768px) { | ||
| .markdown-table { | ||
| font-size: 12px; | ||
| } | ||
|
|
||
| .markdown-table th, | ||
| .markdown-table td { | ||
| padding: 8px 4px; | ||
| } | ||
| } | ||
|
|
||
| @media (max-width: 480px) { | ||
| .markdown-table { | ||
| font-size: 11px; | ||
| } | ||
|
|
||
| .markdown-table th, | ||
| .markdown-table td { | ||
| padding: 6px 2px; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import type { MarkedExtension } from './MarkedOptions.ts'; | ||
| import type { Tokens } from './Tokens.ts'; | ||
|
|
||
| export const tableExtension: MarkedExtension = { | ||
| renderer: { | ||
| table(token: Tokens.Table): string { | ||
| let header = ''; | ||
|
|
||
| // header | ||
| let cell = ''; | ||
| for (let j = 0; j < token.header.length; j++) { | ||
| cell += this.tablecell(token.header[j]); | ||
| } | ||
| header += this.tablerow({ text: cell }); | ||
|
|
||
| let body = ''; | ||
| for (let j = 0; j < token.rows.length; j++) { | ||
| const row = token.rows[j]; | ||
|
|
||
| cell = ''; | ||
| for (let k = 0; k < row.length; k++) { | ||
| cell += this.tablecell(row[k]); | ||
| } | ||
|
|
||
| body += this.tablerow({ text: cell }); | ||
| } | ||
| if (body) body = `<tbody>${body}</tbody>`; | ||
|
|
||
| return '<table class="markdown-table">\n' | ||
| + '<thead>\n' | ||
| + header | ||
| + '</thead>\n' | ||
| + body | ||
| + '</table>\n'; | ||
| }, | ||
| tablerow({ text }: Tokens.TableRow): string { | ||
| return `<tr class="markdown-table-row">\n${text}</tr>\n`; | ||
| }, | ||
| tablecell(token: Tokens.TableCell): string { | ||
| const content = this.parser.parseInline(token.tokens); | ||
| const type = token.header ? 'th' : 'td'; | ||
| const tag = token.align | ||
| ? `<${type} align="${token.align}">` | ||
| : `<${type}>`; | ||
| return tag + content + `</${type}>\n`; | ||
| }, | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // Test case for issue #2832 - bullet rendering with 4-space indentation | ||
| import { marked } from './lib/marked.esm.js'; | ||
|
|
||
| const testCases = [ | ||
| { | ||
| name: 'Empty nested item with 4-space indentation', | ||
| markdown: `- title | ||
| - desc | ||
| -`, | ||
| }, | ||
| { | ||
| name: 'Empty nested item with 2-space indentation', | ||
| markdown: `- title | ||
| - desc | ||
| -`, | ||
| }, | ||
| ]; | ||
|
|
||
| testCases.forEach((testCase) => { | ||
| console.log(`\n=== ${testCase.name} ===`); | ||
| console.log('Input:'); | ||
| console.log(JSON.stringify(testCase.markdown)); | ||
| console.log('\nOutput:'); | ||
| try { | ||
| const result = marked.parse(testCase.markdown); | ||
| console.log(result); | ||
| } catch(error) { | ||
| console.error('Error:', error.message); | ||
| } | ||
| }); | ||
|
Comment on lines
+1
to
+30
There was a problem hiding this comment. This test file is a great addition to verify the fix. However, it currently only logs the output to the console, requiring manual verification. To make it a robust, automated test, you should convert it to use a test framework like |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
tableExtensionobject is duplicated here and insrc/tableExtension.ts. This creates a maintenance burden, as changes would need to be applied in two places. It would be better to have a single source of truth. Consider compilingsrc/tableExtension.tsto JavaScript and importing it here to avoid code duplication.