Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some content #6

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Added some content #6

wants to merge 9 commits into from

Conversation

hamstar
Copy link

@hamstar hamstar commented Nov 26, 2012

Added some implementations, developers and added another section for libraries that parse markdown.

I also added a favicon (the same as the markdown github repo avatar).

Tested it in jekyll all looks good.

@hamstar
Copy link
Author

hamstar commented Nov 26, 2012

I may have mistaken the meaning of implementors...

<!DOCTYPE html>
<html>
<head>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This had a valid html5 doctype. Why should we change this? I see no reason. Both html and xhtml are valid under html5.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for sticking with <!DOCTYPE html>.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok my bad.

@waylan
Copy link
Member

waylan commented Nov 26, 2012

The favicon is nice, but if it comes from Github, do we have permission to use it? I didn't check, maybe it's licenced in an acceptable manner. But I think we should verify that before using it.

@davidchambers
Copy link
Member

The favicon is nice, but if it comes from Github, do we have permission to use it?

I created the icon, so I think we're okay. ;)

@hamstar
Copy link
Author

hamstar commented Nov 27, 2012

Dammit why didn't I use topic branches!

@hamstar
Copy link
Author

hamstar commented Nov 27, 2012

Unless you guys have a way to pick and choose commits to add, or can do a manual merge/edit/commit/push then reject this pull request and I will submit more coherent content and topic branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants