Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves the partial panel #15

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

rpaul-stripe
Copy link
Collaborator

  • Improves the partials panel to add dedicated "partials" and "references" top-level tree elements so that both are shown at once. Previously, it would only show the partials if the doc is a route and the references if the doc is a partial — not both at once. This led to confusion about what was actually showing up in the panel.
  • Improves the loading behavior of the partial tree panel so that it displays a loading message while the language server is still computing the contents and then updates when the contents are available. Previously, it would just show empty content during loading and would not update until the active tab changed.
  • Makes the panel explicitly show "None" when the doc has no partials or references.
image

@rpaul-stripe rpaul-stripe merged commit b10ee90 into main Jan 9, 2024
2 checks passed
@rpaul-stripe rpaul-stripe deleted the partial-panel-improvements branch January 9, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant