Angular 6 and rxjs 6 support #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raphcal
commented
Sep 3, 2018
Raphcal
commented
- Changed version number to 2.0.0 for Semver compatibility
- Upgraded dependencies version of Angular, RxJS, Zone.js and SystemJS
- Removed lodash dependency
- Added unit tests
Fixed "compare" method for null and undefined values Using const and let when possible Using triple equals to avoid comparison errors Fixed unit test by casting "bulb" to allow assignation to SortOrder type Removed lodash dependency and updated dependencies versions. Updated systemjs and karma configurations Fixed code style. Upgraded version number to 2.0.0 Using SortOrder as argument to better convey the possible values Added unit tests for new code and fixed onSortChange emissions Updated NodeJS version for Travis
Raphcal
force-pushed
the
angular6-rxjs6-support
branch
from
7ad1e51 to
a27e6cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.